Fix the CAS spinlock implementation
Make the spinlock implementation use ARMv8.1-LSE CAS instruction based
on a platform build option. The CAS-based implementation used to be
unconditionally selected for all ARM8.1+ platforms.

The previous CAS spinlock implementation had a bug wherein the spin_unlock()
implementation had an `sev` after `stlr` which is not sufficient. A dsb is
needed to ensure that the stlr completes prior to the sev. Having a dsb is
heavyweight and a better solution would be to use load exclusive semantics
to monitor the lock and wake up from wfe when a store happens to the lock.
The patch implements the same.

Change-Id: I5283ce4a889376e4cc01d1b9d09afa8229a2e522
Signed-off-by: Soby Mathew <soby.mathew@arm.com>
Signed-off-by: Olivier Deprez <olivier.deprez@arm.com>
1 parent ace2368 commit c97cba4ea44910df1f7b1af5dba79013fb44c383
@Soby Mathew Soby Mathew authored on 25 Sep 2019
Olivier Deprez committed on 4 Oct 2019
Showing 5 changed files
View
Makefile
View
docs/design/firmware-design.rst
View
docs/getting_started/user-guide.rst
View
lib/locks/exclusive/aarch64/spinlock.S
View
make_helpers/defaults.mk