diff --git a/plat/nvidia/tegra/common/tegra_bl31_setup.c b/plat/nvidia/tegra/common/tegra_bl31_setup.c index 269afb1..40713b2 100644 --- a/plat/nvidia/tegra/common/tegra_bl31_setup.c +++ b/plat/nvidia/tegra/common/tegra_bl31_setup.c @@ -367,7 +367,15 @@ int32_t bl31_check_ns_address(uint64_t base, uint64_t size_in_bytes) { uint64_t end = base + size_in_bytes - U(1); - int32_t ret = 0; + + /* + * Sanity check the input values + */ + if ((base == 0U) || (size_in_bytes == 0U)) { + ERROR("NS address 0x%llx (%lld bytes) is invalid\n", + base, size_in_bytes); + return -EINVAL; + } /* * Check if the NS DRAM address is valid @@ -376,7 +384,7 @@ (end > TEGRA_DRAM_END)) { ERROR("NS address 0x%llx is out-of-bounds!\n", base); - ret = -EFAULT; + return -EFAULT; } /* @@ -385,9 +393,9 @@ */ if ((base < (uint64_t)TZDRAM_END) && (end > tegra_bl31_phys_base)) { ERROR("NS address 0x%llx overlaps TZDRAM!\n", base); - ret = -ENOTSUP; + return -ENOTSUP; } /* valid NS address */ - return ret; + return 0; }