diff --git a/common/globalvar.c b/common/globalvar.c index a826e1b..c87f2c9 100644 --- a/common/globalvar.c +++ b/common/globalvar.c @@ -175,21 +175,24 @@ return 1; } -static int nv_set(struct device_d *dev, struct param_d *p, const char *val) +static int nv_set(struct device_d *dev, struct param_d *p, const char *name, const char *val) { int ret; if (!val) { - free(p->value); + if (p) + free(p->value); return 0; } - ret = dev_set_param(&global_device, p->name, val); + ret = dev_set_param(&global_device, name, val); if (ret) return ret; - free(p->value); - p->value = xstrdup(val); + if (p) { + free(p->value); + p->value = xstrdup(val); + } return 0; } @@ -203,7 +206,7 @@ { int ret; - ret = nv_set(dev, p, val); + ret = nv_set(dev, p, p->name, val); if (ret) return ret; @@ -234,7 +237,7 @@ return ret; if (value) - return nv_set(&nv_device, p, value); + return nv_set(&nv_device, p, name, value); ret = nvvar_device_dispatch(name, &dev, &pname); if (ret > 0) @@ -242,7 +245,7 @@ else value = dev_get_param(&global_device, name); - if (value) { + if (value && p) { free(p->value); p->value = xstrdup(value); } diff --git a/common/state/state.h b/common/state/state.h index 912d6d4..1881d92 100644 --- a/common/state/state.h +++ b/common/state/state.h @@ -159,7 +159,6 @@ */ struct state_uint32 { struct state_variable var; - struct param_d *param; uint32_t value; uint32_t value_default; }; @@ -169,7 +168,6 @@ */ struct state_enum32 { struct state_variable var; - struct param_d *param; uint32_t value; uint32_t value_default; const char **names; @@ -181,7 +179,6 @@ */ struct state_mac { struct state_variable var; - struct param_d *param; uint8_t value[6]; uint8_t value_default[6]; }; @@ -191,7 +188,6 @@ */ struct state_string { struct state_variable var; - struct param_d *param; char *value; const char *value_default; char raw[]; diff --git a/common/state/state_variables.c b/common/state/state_variables.c index 6a00c82..66c66f3 100644 --- a/common/state/state_variables.c +++ b/common/state/state_variables.c @@ -116,7 +116,6 @@ return ERR_CAST(param); } - su32->param = param; su32->var.type = vtype; su32->var.size = sizeof(uint8_t); #ifdef __LITTLE_ENDIAN @@ -146,7 +145,6 @@ return ERR_CAST(param); } - su32->param = param; su32->var.type = vtype; su32->var.size = sizeof(uint32_t); su32->var.raw = &su32->value; @@ -226,6 +224,7 @@ const struct variable_type *vtype) { struct state_enum32 *enum32; + struct param_d *param; int ret, i, num_names; enum32 = xzalloc(sizeof(*enum32)); @@ -253,11 +252,11 @@ enum32->names[i] = xstrdup(name); } - enum32->param = dev_add_param_enum(&state->dev, name, state_set_dirty, + param = dev_add_param_enum(&state->dev, name, state_set_dirty, NULL, &enum32->value, enum32->names, num_names, &enum32->var); - if (IS_ERR(enum32->param)) { - ret = PTR_ERR(enum32->param); + if (IS_ERR(param)) { + ret = PTR_ERR(param); goto out; } @@ -310,6 +309,7 @@ const struct variable_type *vtype) { struct state_mac *mac; + struct param_d *param; int ret; mac = xzalloc(sizeof(*mac)); @@ -319,10 +319,10 @@ mac->var.raw = mac->value; mac->var.state = state; - mac->param = dev_add_param_mac(&state->dev, name, state_set_dirty, + param = dev_add_param_mac(&state->dev, name, state_set_dirty, NULL, mac->value, &mac->var); - if (IS_ERR(mac->param)) { - ret = PTR_ERR(mac->param); + if (IS_ERR(param)) { + ret = PTR_ERR(param); goto out; } @@ -413,6 +413,7 @@ { struct state_string *string; uint32_t start_size[2]; + struct param_d *param; int ret; ret = of_property_read_u32_array(node, "reg", start_size, @@ -432,11 +433,11 @@ string->var.raw = &string->raw; string->var.state = state; - string->param = dev_add_param_string(&state->dev, name, + param = dev_add_param_string(&state->dev, name, state_string_set, state_string_get, &string->value, &string->var); - if (IS_ERR(string->param)) { - ret = PTR_ERR(string->param); + if (IS_ERR(param)) { + ret = PTR_ERR(param); goto out; } diff --git a/drivers/mci/mci-core.c b/drivers/mci/mci-core.c index e5b5e8a..34aaee5 100644 --- a/drivers/mci/mci-core.c +++ b/drivers/mci/mci-core.c @@ -1822,6 +1822,7 @@ int mci_register(struct mci_host *host) { struct mci *mci; + struct param_d *param_probe; int ret; mci = xzalloc(sizeof(*mci)); @@ -1853,11 +1854,11 @@ dev_info(mci->host->hw_dev, "registered as %s\n", dev_name(&mci->dev)); - mci->param_probe = dev_add_param_bool(&mci->dev, "probe", + param_probe = dev_add_param_bool(&mci->dev, "probe", mci_set_probe, NULL, &mci->probe, mci); - if (IS_ERR(mci->param_probe) && PTR_ERR(mci->param_probe) != -ENOSYS) { - ret = PTR_ERR(mci->param_probe); + if (IS_ERR(param_probe) && PTR_ERR(param_probe) != -ENOSYS) { + ret = PTR_ERR(param_probe); dev_dbg(&mci->dev, "Failed to add 'probe' parameter to the MCI device\n"); goto err_unregister; } diff --git a/include/mci.h b/include/mci.h index 57a4629..d967027 100644 --- a/include/mci.h +++ b/include/mci.h @@ -471,7 +471,6 @@ int dsr_imp; /**< DSR implementation state from CSD */ char *ext_csd; int probe; - struct param_d *param_probe; struct param_d *param_boot; int bootpart; diff --git a/include/param.h b/include/param.h index f1166eb..c79b908 100644 --- a/include/param.h +++ b/include/param.h @@ -118,7 +118,7 @@ const char *(*get)(struct device_d *, struct param_d *p), unsigned long flags) { - return ERR_PTR(-ENOSYS); + return NULL; } static inline struct param_d *dev_add_param_string(struct device_d *dev, const char *name, @@ -126,7 +126,7 @@ int (*get)(struct param_d *p, void *priv), char **value, void *priv) { - return ERR_PTR(-ENOSYS); + return NULL; } static inline struct param_d *__dev_add_param_int(struct device_d *dev, const char *name, @@ -134,7 +134,7 @@ int (*get)(struct param_d *p, void *priv), void *value, enum param_type type, const char *format, void *priv) { - return ERR_PTR(-ENOSYS); + return NULL; } static inline struct param_d *dev_add_param_enum(struct device_d *dev, const char *name, @@ -143,7 +143,7 @@ int *value, const char * const *names, int max, void *priv) { - return ERR_PTR(-ENOSYS); + return NULL; } static inline struct param_d *dev_add_param_bitmask(struct device_d *dev, const char *name, @@ -151,7 +151,7 @@ int (*get)(struct param_d *p, void *priv), unsigned long *value, const char * const *names, int max, void *priv) { - return ERR_PTR(-ENOSYS); + return NULL; } static inline struct param_d *dev_add_param_tristate(struct device_d *dev, const char *name, @@ -159,13 +159,13 @@ int (*get)(struct param_d *p, void *priv), int *value, void *priv) { - return ERR_PTR(-ENOSYS); + return NULL; } static inline struct param_d *dev_add_param_tristate_ro(struct device_d *dev, const char *name, int *value) { - return ERR_PTR(-ENOSYS); + return NULL; } static inline struct param_d *dev_add_param_ip(struct device_d *dev, const char *name, @@ -173,7 +173,7 @@ int (*get)(struct param_d *p, void *priv), IPaddr_t *ip, void *priv) { - return ERR_PTR(-ENOSYS); + return NULL; } static inline struct param_d *dev_add_param_mac(struct device_d *dev, const char *name, @@ -181,13 +181,13 @@ int (*get)(struct param_d *p, void *priv), u8 *mac, void *priv) { - return ERR_PTR(-ENOSYS); + return NULL; } static inline struct param_d *dev_add_param_fixed(struct device_d *dev, const char *name, const char *value) { - return ERR_PTR(-ENOSYS); + return NULL; } static inline void dev_remove_param(struct param_d *p) {}