diff --git a/commands/digest.c b/commands/digest.c index b6bce88..340c07a 100644 --- a/commands/digest.c +++ b/commands/digest.c @@ -17,8 +17,7 @@ #include "internal.h" -int __do_digest(struct digest *d, unsigned char *key, int keylen, - unsigned char *sig, +int __do_digest(struct digest *d, unsigned char *sig, int argc, char *argv[]) { int ret = COMMAND_ERROR_USAGE; @@ -28,17 +27,6 @@ if (argc < 1) goto err; - if (key) { - ret = digest_set_key(d, key, keylen); - if (ret) { - perror("set_key"); - goto err; - } - } else if (digest_is_flags(d, DIGEST_ALGO_NEED_KEY)) { - eprintf("%s need a key to be used\n", digest_name(d)); - goto err; - } - hash = calloc(digest_length(d), sizeof(unsigned char)); if (!hash) { perror("calloc"); @@ -147,10 +135,15 @@ } } - ret = digest_set_key(d, key, keylen); - free(tmp_key); - if (ret) + if (key) { + ret = digest_set_key(d, key, keylen); + free(tmp_key); + if (ret) + goto err; + } else if (digest_is_flags(d, DIGEST_ALGO_NEED_KEY)) { + eprintf("%s need a key to be used\n", digest_name(d)); goto err; + } if (sigfile) { sig = tmp_sig = read_file(sigfile, &siglen); @@ -178,7 +171,7 @@ } } - ret = __do_digest(d, NULL, 0, sig, argc, argv); + ret = __do_digest(d, sig, argc, argv); free(tmp_sig); return ret; diff --git a/commands/hashsum.c b/commands/hashsum.c index dc48af5..e2dc70e 100644 --- a/commands/hashsum.c +++ b/commands/hashsum.c @@ -34,7 +34,7 @@ struct digest *d; unsigned char *key = NULL; size_t keylen = 0; - int opt; + int opt, ret; while((opt = getopt(argc, argv, "h:")) > 0) { switch(opt) { @@ -49,15 +49,22 @@ char *tmp = asprintf("hmac(%s)", algo); d = digest_alloc(tmp); free(tmp); + BUG_ON(!d); + + ret = digest_set_key(d, key, keylen); + if (ret) { + perror("set_key"); + return ret; + } } else { d = digest_alloc(algo); + BUG_ON(!d); } - BUG_ON(!d); argc -= optind; argv += optind; - return __do_digest(d, key, keylen, NULL, argc, argv); + return __do_digest(d, NULL, argc, argv); } #ifdef CONFIG_CMD_MD5SUM diff --git a/commands/internal.h b/commands/internal.h index 29cc656..21d1408 100644 --- a/commands/internal.h +++ b/commands/internal.h @@ -1,3 +1,2 @@ -int __do_digest(struct digest *d, unsigned char *key, int keylen, - unsigned char *sig, +int __do_digest(struct digest *d, unsigned char *sig, int argc, char *argv[]);