state: storage: initialize variable once outside loop ...

writesize is initialized with the same value in each loop iteration,
Instead, initialize it once outside the loop.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

state: pass struct state * to storage functions ...

We can get a state_backend_storage * and the device * from struct state,
so pass this to the storage functions rather than the two pointers.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

state: remove unnecessary argument from state_format_init ...

The device pointer is already in struct state, no need to pass it
around when a struct state * is already passed.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

state: open code state_backend_init in caller ...

Safes a lot of argument passing to a function that is used
only once.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

state: merge backend.c into state.c ...

The code in backend.c is too small to justify an extra file. Merge it
into state.c.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

state: Drop backend as extra struct type ...

struct state_backend is embedded into struct state. This additional
indirection does not have any real gain. Drop it.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

state: backend: remove len_hint argument from state_storage_read ...

The argument is 0 in the only caller, so remove the argument.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

state: backend: remove .get_packed_len ...

.get_packed_len isn't implemented by any backend, so remove the
hook and its potential caller.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

state: Use positive logic ...

bools with "non" in the names are rather confusing. Switch to
positive logic.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

state: pass error code instead of inventing new one ...

Both of_find_path() and of_find_path_by_node() return a meaningful
error code, so forward it instead of inventing a new one. Do this
especially for the -EPROBE_DEFER case which currently does not work.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

state: fix finding the correct parent node ...

Looking for the parent node during fixup is broken. The path of the parent
node is not correctly terminated ('0' vs '\0'). Also, the new state node
should be added to the supplied device tree not the barebox device tree
used by of_find_node_by_path().

Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

barebox-state: Sync pieces with barebox ...

dev_add_param_bool are no-ops, save_on_shutdown is irrelevant for the
userspace part. Sync with barebox as of v2017.03.0

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

state: don't keep pointers to device tree nodes ...

Caching pointers to device tree nodes or is not save. The barebox internal
device tree may be changed by loading a new device tree or through fixup
handlers. As a result, the node may be deleted and replaced with a new one.
Keep a copy of the full path instead and resolve the node as needed.

Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

state: make locally used function static ...

state_set_dirty() is only used in one file, make it static.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

state: consistently pass one type as private data to dev_add_param_* ...

The different dev_add_param_* calls all use different types as private
data. This is unnecessary, use struct state_variable * for all of them.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

state: Add state to state_variable ...

A state variable should know which state it belongs to. Add field
for it to struct state_variable.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

state: copy backend of_path string ...

Caching pointers to device tree nodes or names is not safe. The barebox
internal device tree may be changed by loading a new device tree or through
fixup handlers. As a result, the string may be deleted.
Use local copies of the full path instead.

Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

Revert "barebox-state: Do not defer probe" ...

This reverts commit 898a467.

Revert "barebox-state: Add force switch" ...

This reverts commit 89135e5.

state: use packed attribute for on storage structs ...

These structs are used for on-storage data layouts. They should be not
affected by different integer precisions and alignment optimizations of
32bit or 64bit machines. Using the architecture independent integer data
types, like uint32_t, achieves the former, using the packed attribute
the later.

Signed-off-by: Stefan Lengfeld <s.lengfeld@phytec.de>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

state: Whitespace cleanup ...

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

state: bucket_circular: -EUCLEAN means data could be read ...

-EUCLEAN returned from state_mtd_peb_read() means that the
data shall still be used. This fixes initialization of buckets
which need cleanup.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

state: bucket_cached: Fix reading pages which need cleanup ...

When the raw device returns -EUCLEAN we have to return
successfully to the upper layer, otherwise it will discard the
data.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

barebox-state: Add force switch ...

The force switch allows to read from a state even when the
keystore blobs cannot be read.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

barebox-state: Do not defer probe ...

This makes no sense in the user space tool, remove it.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

rework logging functions ...

We already use pr_* and dev_* functions. Replace some more
fprintf(stderr,...) with appropriate pr_* function calls. Also
provide control over which urgency level is printed.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

of_print_property: fix compiler warning ...

src/libdt.c: In function ‘of_print_property’:
src/libdt.c:97:13: warning: format ‘%s’ expects argument of type ‘char *’, but argument 2 has type ‘const void *’ [-Wformat=]

Calm the compiler with an explicit cast.

of_get_devicepath: correct comment and add link to external patch

of_get_devicepath: make partition finding more robust ...

If a backing device for a partition is neither an eeprom nor an mtd nor a
block device I don't know what it should be. Still fall back to the generic
case where the partition doesn't have a related of_node.

of_get_devicepath: if the device is an mtd udev_parse_mtd is all we need. ...

So the function should return success and not fall back to the "there is no
associated device" case.

Fixes: d83976b8163d ("libdt: add block devicepath extraction")