Fork: 0
LuminaSensum / barebox
Browse code
scripts/mkimage: Fix strncpy usage
Original code produces the following warning when compiled with GCC8:

  HOSTCC  scripts/mkimage
In function ‘image_set_name’,
    inlined from ‘main’ at scripts/mkimage.c:614:2:
scripts/mkimage.c:153:2: warning: ‘strncpy’ specified bound 32 equals destination size [-Wstringop-truncation]
  strncpy(image_get_name(hdr), name, IH_NMLEN);
  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

reduce specified bound by one to make sure that NULL-terminator is
never overwritten.

Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
WIP_next-LS master next stable/v2018.07 stable/v2018.09 stable/v2018.12 v2020.07.0 v2020.06.0 v2020.05.0 v2020.04.0 v2020.03.0 v2020.02.0 v2020.01.0 v2019.12.0 v2019.11.0 v2019.10.0 v2019.09.0 v2019.08.1 v2019.08.0 v2019.07.0 v2019.06.1 v2019.06.0 v2019.05.0 v2019.04.0 v2019.03.0 v2019.02.0 v2019.01.0 v2018.12.0 v2018.11.0 v2018.10.0 v2018.09.1 v2018.09.0 v2018.08.1 v2018.08.0 v2018.07.2 v2018.07.1 v2018.07.0
1 parent 0d4a439 commit 6a8fee6c4eaec4f2575ce59b1b78eafd144633e2
@Andrey Smirnov Andrey Smirnov authored on 22 May 2018
Sascha Hauer committed on 23 May 2018
Patch
Unified Split
Showing 1 changed file
View
scripts/mkimage.c