LuminaSensum/barebox

Fork: 0

LuminaSensum / barebox

History for barebox / arch / arm / include / asm / common.h

2018-08-08	f9fc825 Browse files » ARM: Mark SP as being clobbered in arm_setup_stack() ... Not sure why it was working before, but with recent update of AArch64 GCC to 8.1.1 on my Fedora 28 machine, compiling barebox_arm_entry() yields the following assembly: 0000000000002aac <barebox_arm_entry>: 2aac: a9bd7bfd stp x29, x30, [sp, #-48]! 2ab0: d1404023 sub x3, x1, #0x10, lsl #12 2ab4: d1004063 sub x3, x3, #0x10 2ab8: 910003fd mov x29, sp 2abc: 8b000063 add x3, x3, x0 2ac0: a90153f3 stp x19, x20, [sp, #16] 2ac4: aa0003f3 mov x19, x0 2ac8: aa0103f4 mov x20, x1 2acc: f90017e2 str x2, [sp, #40] <-- storing 'boarddata' on old stack 2ad0: 9100007f mov sp, x3 <-- setting up new stack 2ad4: 97ffffdd bl 2a48 <arm_early_mmu_cache_invalidate> 2ad8: f94017e2 ldr x2, [sp, #40] <--- sadness 2adc: aa1403e1 mov x1, x20 2ae0: aa1303e0 mov x0, x19 2ae4: 940000a1 bl 2d68 <barebox_multi_pbl_start> Which result in AArch64 image (i.MX8MQ) not being bootable. With SP marked as clobbered, the above assembly changes to the following: 0000000000002aac <barebox_arm_entry>: 2aac: a9bd7bfd stp x29, x30, [sp, #-48]! 2ab0: d1404023 sub x3, x1, #0x10, lsl #12 2ab4: d1004063 sub x3, x3, #0x10 2ab8: 910003fd mov x29, sp 2abc: a90153f3 stp x19, x20, [sp, #16] 2ac0: 8b000063 add x3, x3, x0 2ac4: aa0003f3 mov x19, x0 2ac8: aa0103f4 mov x20, x1 2acc: f90017a2 str x2, [x29, #40] 2ad0: 9100007f mov sp, x3 2ad4: 97ffffdd bl 2a48 <arm_early_mmu_cache_invalidate> 2ad8: f94017a2 ldr x2, [x29, #40] 2adc: aa1403e1 mov x1, x20 2ae0: aa1303e0 mov x0, x19 2ae4: 940000a1 bl 2d68 <barebox_multi_pbl_start> now x29 is used to access stored x2 which avoids the problem and allows the system to boot correctly. The change is a no-op on AArch32. Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> Andrey Smirnov authored on 7 Aug 2018 Sascha Hauer committed on 8 Aug 2018
2018-03-21	f98ecf9 Browse files » ARM: aarch64: implement get_pc() ... The arm32 version can't be used on aarch64, implement an aarch64 specific version. Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> Sascha Hauer committed on 21 Mar 2018
2015-07-13	74438aa Browse files » exitcall: move arch_shutdown to exitcall infrastructure ... Signed-off-by: Herve Codina <Herve.CODINA@celad.com> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> Herve Codina authored on 6 Jul 2015 Sascha Hauer committed on 13 Jul 2015
2015-01-05	0160f83 Browse files » ARM: Add get_sp() and get_lr() functions ... In case it's needed for some early code. Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> Sascha Hauer committed on 5 Jan 2015
2012-10-13	8b609af Browse files » ARM: introduce arm_setup_stack function and use it ... We have enough places which setup0 a stack to justify a static inline function for it. Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> Sascha Hauer committed on 13 Oct 2012
2010-05-03	6b8e614 Browse files » add arm helper function to determine the program counter ... Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> Sascha Hauer committed on 3 May 2010
2010-03-30	cf2703a Browse files » ARM: replace cleanup_before_linux with the generic shutdown_barebox function ... Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> Sascha Hauer committed on 30 Mar 2010
2009-10-22	67254a4 Browse files » [ARM] move include/asm-arm to arch/arm/include/asm ... Move platform independent header files to arch/arm/include/asm, leaving those in asm/arch* and asm/proc* alone. Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com> Jean-Christophe PLAGNIOL-VILLARD committed on 22 Oct 2009