Merge branch 'for-next/misc'

Merge branch 'for-next/lseek'

devfs: Drop dev_lseek_default() ...

Only the following cdevs do not declare an .lseek() operation:

  - Console devices in common/console.c
  - Firmware framework in common/firmware.c
  - JTAG driver in drivers/misc/jtag.c
  - UBI in drivers/mtd/ubi/barebox.c

Of those four, first two are marked DEVFS_IS_CHARACTER_DEV and
implement only .write() operation and the last two don't implement
anything but .ioctl(). While there's probably no meaningful way to use
lseek() against any of those devices, there doesn't seem to be any
harm in allowing it either.

Change devfs_lseek() to ignore absense of .lseek() callback and drop
dev_lseek_default() and all references to it in the codebase.

Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

commands: Move /dev/mem driver to drivers/misc ...

With all other code gone from commands/mem.c, move it into
driver/misc, where it fits better. While at it, expose it directly via
a Kconfig options instead of relying on CONFIG_COMPILE_MEMORY

Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

commands: Get rid of mem_rw_buf ...

There doesn't seem to be any good reason for all of the memory
commands (md, mw, etc.) to rely on a shared pre-allocated buffer
anymore. So, to simplify things, drop the shared buffer and adjust all
of the utilites to allocate needed memory.

Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

commands: Move mem_parse_options() to lib/misc.c ...

As a first step of de-cluttering /dev/mem related code, move
mem_parse_options() out of commands/mem.c into lib/misc.c where it
seem to fit better. With this change we no longer explicitly turn this
code off using CONFIG_COMPILE_MEMORY and instead rely on LTO to get
rid of it when it's not being used.

While at it, also fix return value by replacing COMMAND_ERROR_USAGE
with -EINVAL. All of the callers of mem_parse_options() expect
negative error code as a sign of failure and COMMAND_ERROR_USAGE is
not negative.

Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

i2c_probe: Use a quick write transfer instead of writing a zero ...

This matches the method implemented in i2cdetect(8) when using its -q
option.

With this change an rx8130 RTC is detectable using i2c_probe. This
failed before because this chip acks the first byte (containing its
address and the R/̅W bit) but nacks the following 0 (representing the
target address to write nothing to) which makes i2c_write_reg() return
with an error and so the chip is not listed as available.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

i2c_probe: limit slave addresses to [0x04, 0x77] ...

Adresses below 0x04 and above 0x77 are reserved in the i2c bus
specification, so don't probe these addresses unless requested
explicitly.

Also do more strict boundary checking:

 - ensure start address is greater or equal to zero;
 - don't decrease stopaddr after checking it being greater or equal to
   startaddr.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

ls: Adjust amount of space allocated for filesize ...

Maximum file size on 64-bit system is 2^63-1 (9223372036854775807),
which takes more that 14 characters of space. In order to keep things
properly aligned adjust that spacing to 20 on 64-bit platforms.

Before:

ls -l /dev/
d---------              0 .
d---------              0 ..
crw-------          16384 dds-eeprom
crw-------            256 e1000-invm0
crw-------          16384 eeprom0
cr--------              0 full
crw-------           2048 imx-ocotp
crw-------          16384 main-eeprom
crw-------             64 mdio0-phy00
crw------- 9223372036854775807 mem
c-w-------              0 netconsole-1
c-w-------              0 null
crw-------   256060514304 nvme0n1
cr--------              0 prng
crw-------     4294967296 ram0
c-w-------              0 serial0-1
cr--------              0 zero

After:

ls -l /dev/
d---------                   0 .
d---------                   0 ..
crw-------               16384 dds-eeprom
crw-------                 256 e1000-invm0
crw-------               16384 eeprom0
cr--------                   0 full
crw-------                2048 imx-ocotp
crw-------               16384 main-eeprom
crw-------                  64 mdio0-phy00
crw------- 9223372036854775807 mem
c-w-------                   0 netconsole-1
c-w-------                   0 null
crw-------        256060514304 nvme0n1
cr--------                   0 prng
crw-------          4294967296 ram0
c-w-------                   0 serial0-1
cr--------                   0 zero

Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

commands: digest: Use MAX_LFS_FILESIZE instead of ~0 ...

Loff_t is a signed type, so ~0 is a negative number. While it works OK
due to clamping/conversion to ulong when passed to
digest_file_window(), it is better not to rely on that fact and use an
appropriate constant.

Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

treewide: Introduce MAP_FAILED and replace ad-hoc constants with it ...

Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

Merge branch 'for-next/net'

net: ip_route_get: resolv hostnames ...

When global.net.server is a hostname instead of an IP address we have to
resolv it.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

net: ip_route_get: Hook help text to command ...

The help text is present but not hooked into the command structure. Fix
this.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

net: ip_route_get: Fix error message ...

We do getopt(), so the next argument is in argv[optind], not in argv[1].

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

commands: nand-bitflip: Add documentation for option '-c' ...

Signed-off-by: Teresa Remmet <t.remmet@phytec.de>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

commands: miitool: remove unsupported options a and b ...

Signed-off-by: Andreas Schmidt <andreas.schmidt@wago.com>

commands: boot: Remove useless code ...

All of those variables are already initialized in-place in the
variable declaration section above to exactly the same values

Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

ubimkvol: add support for `volume_id` parameter ...

The volume id can be used to refer to a specific volume.
This adds support to choose a corresponding argument when creating
a UBI volume.

Signed-off-by: Leif Middelschulte <leif.middelschulte@gmail.com>

mount command: Fix "mount /dev/<devname>" ...

We used to put the device name without the "/dev/" component into
device_detect_by_name() and cdev_by_name(). Since 8ca7053b3ff we only
put the device name into device_detect_by_name(), but cdev_by_name()
still gets the full path. The result is that a "mount /dev/<devname>" no
longer works. Fix this.

Fixes: 8ca7053b3ff ("commands: mount: Make use of devpath_to_name()")

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Andrey Smirnov <andrew.smirnov@gmail.com>

commands: mem: Fix compiler warning ...

resource_size_t may be 32bit on several architectures, so explicitly do
a 64bit comparison to avoid "warning: comparison of distinct pointer types
lacks a cast".

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

Merge branch 'for-next/usb'

Merge branch 'for-next/misc'

commands: mem: truncate mem device size to fit the loff_t file size ...

On 64bit arches the file covering the whole address space is larger than
what can be represented in the loff_t type (s64) used for the file size.
Thus the size of this device is interpreted as negative in a lot of
places. Fix this by truncating the size to fit the file size type.

Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

usbgadget: autostart: add DFU support ...

Use global variable dfu_function to autostart DFU. As similar code
is used to start multifunction gadget using command, move common
code to common/usbgadget.c and consolidate it.
It turned out that '-s' option of usbgadget command does nothing,
so remove its help text and make it function as '-a'.

Signed-off-by: Ladislav Michl <ladis@linux-mips.org>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

commands: gpio: Allow GPIOs to be specified by label ...

Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

commands: gpio: Use kstrtoint() instead of simple_strtoul() ...

Use kstrtoint() instead of simple_strtoul() in order to properly
handle invalid arguments. Current code using simple_strtoul() results
in following:

barebox@ZII RDU2 Board:/ gpio_get_value foo
barebox@ZII RDU2 Board:/ echo $?
0

whereas with this patch we get:

barebox@ZII RDU2 Board:/ gpio_get_value foo
gpio_get_value: Invalid argument

Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

commands: gpio: Move argument parsing into a shared function ...

Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

miitool: Fix inconsistent spacing ...

Make sure that there's a space between device name and it's status
string regardless if if device is using "id" field or not.

Before:

barebox@ZII RDU2 Board:/ miitool
mdio0-phy00: mdio:no link
mdio1-phy15: 2188000.ethernet@2188000:10 Mbit, half duplex, no link
mdio1-phy16: 2188000.ethernet@2188000:10 Mbit, half duplex, no link
mdio2-phy00: 2188000.ethernet@2188000:mdio:switch@0:no link
mdio2-phy01: 2188000.ethernet@2188000:mdio:switch@0:no link
mdio2-phy02: 2188000.ethernet@2188000:mdio:switch@0:negotiated 100baseTx-FD, link ok
mdio2-phy03: 2188000.ethernet@2188000:mdio:switch@0:no link
mdio2-phy04: 2188000.ethernet@2188000:mdio:switch@0:no link
mdio3-phy01: eth1: negotiated 1000baseT-FD flow-control, link ok

After:

barebox@ZII RDU2 Board:/ miitool
mdio0-phy00: mdio: no link
mdio1-phy15: 2188000.ethernet@2188000: 10 Mbit, half duplex, no link
mdio1-phy16: 2188000.ethernet@2188000: 10 Mbit, half duplex, no link
mdio2-phy00: 2188000.ethernet@2188000:mdio:switch@0: no link
mdio2-phy01: 2188000.ethernet@2188000:mdio:switch@0: no link
mdio2-phy02: 2188000.ethernet@2188000:mdio:switch@0: no link
mdio2-phy03: 2188000.ethernet@2188000:mdio:switch@0: no link
mdio2-phy04: 2188000.ethernet@2188000:mdio:switch@0: no link
mdio3-phy01: eth1: no link

Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

Merge branch 'for-next/misc'