mtd: nand: nand_omap_gpmc: Fix mtd_info usage ...

The mtd_info has not been set correctly in the omap gpmc probe.
Remove the mtd_info in the private struct like it has been done in
other nand drivers. And update the driver accordingly.

Fixes: 76b6f74c5397 ("mtd: nand: Embed struct mtd_info into struct nand_chip")

Signed-off-by: Teresa Remmet <t.remmet@phytec.de>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

Merge branch 'for-next/omap'

Merge branch 'for-next/mtd'

mtd: spi-nor: Import missing Micron devices ...

Import entries for n25q00a, mt25qu02g, mt25ql02g, supported by latest
Linux kernel.

Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

mtd: spi-nor: Add support for s25fl128s0 s25fl128s1 flashes from Linux ...

These definitions are taken from Linux's spi-nor driver as of v5.2-rc4

Signed-off-by: DU HUANPENG <u74147@gmail.com>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

mtd: peb: Add function to write file ...

This adds a function to the mtd peb API to write a file spanning
multiple blocks to a mtd device. Bad blocks are automatically skipped
and before anything is done we check if the image will fit into the
remaining space (honouring bad blocks).

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

mtd: nand: gpmc: Add BCH16 support ...

This adds support for BCH16 ECC encoding. The support is mostly taken
from Linux-5.3-rc6. One major change is the different wrap mode used.
The Kernel uses wrapmode 1, which means "pass all data through the BCH
engine". Still the Kernel has to skip the OOB marker which is done by
reading all user data, then use NAND_CMD_RNDOUT to position right
behind the OOB marker and then read the ECC data. Instead of doing this
we use wrap mode 4 which allows us to bypass the OOB marker from the
BCH engine automatically. This explains

bch_wrapmode = 1, eccsize0 = 0, eccsize1 = 52 vs.
bch_wrapmode = 4, eccsize0 = 4, eccsize1 = 52

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

mtd: nand: gpmc: Add support for ELM ...

This adds support for the ELM (Error Location Module) found on
not-too-old OMAP SoCs. The driver has been taken from Linux-5.3-rc6
with interrupt support removed.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

mtd: nand: Embed struct mtd_info into struct nand_chip ...

Similar to what is done in the Kernel. In the Kernel we have a struct
nand_device embedded into struct nand_chip and the nand_device has an
mtd_info embedded into it. Until we have struct nand_device we embed
mtd_info directly into the nand_chip.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

mtd: nand: denali: Add variables for mtd_info and nand_chip ...

Accessing the mtd_info from the nand_chip will change in the next patch,
so instead of accessing it each time when used create a variable for
mtd_info to keep the next patch smaller.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

mtd: nand: Add and use static inline wrapper for getting nand_chip from mtd ...

All drivers in tree use mtd->priv for the nand_chip. Add and use a static
inline wrapper mtd_to_nand() which we already have in the kernel for
getting the nand_chip from the mtd_info struct. Next step would be to
embed a struct mtd_info into struct nand_chip.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

mtd: spi-nor: add support for sst26vf series ...

Ported from linux-4.19-at91 linux4sam_6.1 and needed for
SAMA5D27 SOM1 EK.

Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

mtd: spi-nor: add UNLOCK_GLOBAL_BLOCK support ...

Ported from linux-4.19-at91 linux4sam_6.1 and needed for
SAMA5D27 SOM1 EK.

Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

Merge branch 'for-next/mtd-gpmi-nand'

mtd: nand-mxs: Make ecc strength configurable via device tree ...

According to the binding doc the mxs NAND driver supports the
"nand-ecc-strength" and "nand-ecc-step-size" options. This adds support
for these options to the driver. The "nand-ecc-step-size" is not
really configurable, the only accepted value is 512 so this is merely
to sanity check that there's nothing specified that we can't yet
support.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

mtd: nand: Add function to parse device tree properties ...

This adds nand_of_parse_node() which can be used to parse generic
NAND device properties. Not very complete yet, but it's a start.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

mtd: nand-mxs: inline only once used function ...

mxs_nand_ecc_size_in_bits() is used only once and is simple enough to
be inlined.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

mtd: nand-mxs: pass mtd_info to mxs_nand_get_mark_offset() ...

struct mtd_info * contains everything mxs_nand_get_mark_offset() needs,
so pass this pointer rather than several integer arguments.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

mtd: nand-mxs: change API between NAND driver and fcb code ...

The imx-bbu-nand-fcb update handler code calls into the NAND driver
to get the ecc strength and bad block marker position. Change the
API so that only a single function is necessary and not three functions.
Also in future the ecc strength will be configurable via device tree.
This means static parameters like page size / oob size are no longer
enough to calculate the ecc strength and so we store a pointer to our
mtd_info struct in a static global variable.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

mtd: nand-mxs: Make locally used variable static ...

fake_ecc_layout is only used in the mxs nand driver, so make it static.
Also it's not necessary to zero the structure.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

mtd: nand-mxs: calculate ecc_strength only once ...

Instead of calculating the ecc strength multiple times with each page
read just do it once and store the result in chip->ecc.strength.

While at it also store the correct value in chip->ecc.bytes instead of
writing a bogus value into it.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

mtd: nand-mxs: consistently rename struct nand_chip * to "chip" ...

The struct nand_chip * is sometimes named "nand" and sometimes "chip".
For consistency name it "chip" throughout the driver.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

mtd: spi-nor: fix page offset/remains calculation in spi_nor_write ...

nor->write() simply adds the number of written bytes to the pointer
given. Thus retval is incremented in each loop cycle for each
spi_nor_write() call without ever resetting it. This leads to wrong page
offset/remains calculations and an incorrect number of bytes written to
retlen.

This becomes apparant only if the calling function actually compares len
and retlen (e.g. mtd_peb_write() ). Otherwise wrong data is written:

  $ memcpy -s /dev/prng -d prng_data 0 0 10k
  $ erase /dev/mtd0.mypart
  $ cp prng_data /dev/mtd0.mypart
  $ memcmp -s prng_data -d /dev/mtd0.mypart 0 0

memcmp returned "files differ" before, with this patch it returns "OK".

Fixes: c8516869c4 ("spi: Extend the core to ease integration of SPI memory controllers")
Signed-off-by: Bastian Krause <bst@pengutronix.de>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

mtd: nand: Add ecc parameters as device parameters ...

The ecc strength/bytes/size values are useful informations sometimes,
add them as device parameters.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

UBI: silence erroneous GCC warning about uninitialized read ...

GCC reports following use of an uninitialized variable:

  ./drivers/mtd/ubi/eba.c: In function 'try_write_vid_and_data':
  ./drivers/mtd/ubi/eba.c:904:9: warning:
    'opnum' may be used uninitialized in this function [-Wmaybe-uninitialized]
       err = ubi_wl_put_peb(ubi, vol_id, lnum, opnum, 0);
             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

This is incorrect, because it's only called when err == 0 and opnum
is always initialized if err == 0. Silence the warning by initializing
a variable.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

mtd: peb: Do not mark as bad in mtd_peb_torture() ...

Both the Kernel and mtd-utils have peb torture functions and both
do not mark the block as bad automatically. Instead, the caller
must mark the block as bad when -EIO is returned from the torture
function. Do the same in barebox. This is necessary as the UBI code
otherwise may mark a block as bad twice: Once indirectly in
mtd_peb_torture() and then directly afterwards.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

mtd: ubi: mark PEBs as bad on erase failure ...

70542a9c65 converted UBI to use mtd_peb_torture(). It was assumed that a
block was marked as bad when it didn't pass the torture test. However,
not all possibly bad blocks went through the torture test, so it could
happen that a block that could not be erased was still kept as good
block. This patch fixes this and explicitly calls ubi_io_mark_bad() when
a block cannot be erased.

Fixes: 70542a9c65 ("mtd: ubi: Use mtd_peb_torture")
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

mtd: spi-nor: Add support for ISSI flashes from Linux ...

The definitions are taken from Linux's spi-nor driver as of v5.2-rc4.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

Merge branch 'for-next/misc'

nand: nand_mxs: Do not zero out DMA coherent memory ...

Memory returned by dma_alloc_coherent() should already be zeroed
out, so there's no need to do this explicitly.

Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>