state: remove unused arguments from state_new_from_node() ...

Other than in barebox the offset and size of a state's backend device do not
necessarily equal zero in Linux userspace (EEPROMs & block devices). So we have
to consider that and differentiate between both usecases here while porting the
following barebox commit and removing the now no longer used noop definition of
of_find_path_by_node():

| commit a66a8d7
| Author: Sascha Hauer <s.hauer@pengutronix.de>
| Date:   Tue Feb 20 12:21:00 2018 +0100
|
|     state: remove unused arguments from state_new_from_node()
|
|     state_new_from_node() has arguments describing the backend path. These
|     are never used in barebox, the backend path is always derived from the
|     device nodes backend description. Remove these arguments.
|
|     Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>
[rhi: fixed tabs vs. spaces indentation in state_new_from_node()]
Signed-off-by: Roland Hieber <rhi@pengutronix.de>

state: Add 'init_from_defaults' parameter ...

This ports the following barebox commit:

| commit 6a77d1c
| Author: Sascha Hauer <s.hauer@pengutronix.de>
| Date:   Wed May 4 12:01:05 2016 +0200
|
|     state: Add 'init_from_defaults' parameter
|
|     The init_from_defaults parameter allows to detect if a state has been
|     initialized from default values, i.e. state_load failed.
|
|     Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>
Signed-off-by: Roland Hieber <rhi@pengutronix.de>

state: refuse to set dirty parameter via setenv ...

This ports the following barebox commit:

| commit 6d3e10c
| Author: Sascha Hauer <s.hauer@pengutronix.de>
| Date:   Wed May 4 11:59:59 2016 +0200
|
|     state: refuse to set dirty parameter via setenv
|
|     The dirty parameter is readonly, so refuse to set it.
|
|     Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>
Signed-off-by: Roland Hieber <rhi@pengutronix.de>

state: Add function to read state MAC ...

This ports the following barebox commit:

| commit 09f15cd
| Author: Daniel Schultz <d.schultz@phytec.de>
| Date:   Fri Nov 3 11:48:28 2017 +0100
|
|     common: state: Add function to read state MAC
|
|     This API function allows to receive a copy of a MAC address from
|     variables in a state.
|
|     Signed-off-by: Daniel Schultz <d.schultz@phytec.de>
|     Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>
Signed-off-by: Roland Hieber <rhi@pengutronix.de>

state: refactor variable type ...

This ports the following barebox commits and adjusts the handling of type
information of state variables in barebox-state:

| commit 7b3d284
| Author: Sascha Hauer <s.hauer@pengutronix.de>
| Date:   Mon Apr 3 22:51:58 2017 +0200
|
|     state: remove unused variable type
|
|     enum state_variable_type is never used. Remove it.
|
|     Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

| commit 7126dff
| Author: Daniel Schultz <d.schultz@phytec.de>
| Date:   Fri Nov 3 11:48:26 2017 +0100
|
|     common: state: Add variable_type to state_variable
|
|     Add a pointer in state_variable to the corresponding variable_type array
|     element.
|
|     Signed-off-by: Daniel Schultz <d.schultz@phytec.de>
|     Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

| commit dc74265
| Author: Daniel Schultz <d.schultz@phytec.de>
| Date:   Fri Nov 3 11:48:27 2017 +0100
|
|     common: state: Add variable type as enum
|
|     The variable_type struct holds a name of its type. Checking the type of
|     a variable with this string needs much resources.
|
|     This patch introduce a enum of the variable type for better type
|     checking.
|
|     Signed-off-by: Daniel Schultz <d.schultz@phytec.de>
|     Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>
[rhi: fixed function parameter alignment in common/state/state_variables.c,
  and submitted those changes as patches for barebox:
  https://www.mail-archive.com/barebox@lists.infradead.org/msg29427.html
  https://www.mail-archive.com/barebox@lists.infradead.org/msg29462.html ]
Signed-off-by: Roland Hieber <rhi@pengutronix.de>

state: provide an error message when an error occurs ...

This ports the following barebox commit:

| commit 8db7a23
| Author: Juergen Borleis <jbe@pengutronix.de>
| Date:   Wed Aug 16 14:27:07 2017 +0200
|
|     state: provide an error message when an error occurs
|
|     A simple typo makes the state framework fail, but without an error
|     message the developer is lost in the dark.
|
|     Signed-off-by: Juergen Borleis <jbe@pengutronix.de>
|     Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>
Signed-off-by: Roland Hieber <rhi@pengutronix.de>

state: add debugging help ...

This ports the following barebox commit:

| commit b6a3532
| Author: Juergen Borleis <jbe@pengutronix.de>
| Date:   Tue Aug 15 15:46:35 2017 +0200
|
|     state: add debugging help
|
|     While working on the state documentation it turns out to be helpful to have
|     more debug messages while a developer implements a 'state' variable set
|     and tries to configure it correctly.
|
|     Signed-off-by: Juergen Borleis <jbe@pengutronix.de>
|     Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>
Signed-off-by: Roland Hieber <rhi@pengutronix.de>

state: do not complain about missing backend-storage-type ...

This ports the following barebox commit:

| commit 02a0af2
| Author: Sascha Hauer <s.hauer@pengutronix.de>
| Date:   Tue May 23 09:31:29 2017 +0200
|
|     state: do not complain about missing backend-storage-type
|
|     backend-storage-type is irrelevant for mtd devices, so do not
|     complain about this option missing. The mtd backend will print
|     messages if necessary.
|
|     Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>
Signed-off-by: Roland Hieber <rhi@pengutronix.de>

state: remove unused variables ...

This ports the following barebox commit:

| commit d528a3b
| Author: Sascha Hauer <s.hauer@pengutronix.de>
| Date:   Thu May 11 10:06:24 2017 +0200
|
|     state: remove unused variables
|
|     There's no need to check for the existence of the backend property as
|     this is done implicitly later anyway. With this check removed of_path
|     is only assigned, but never used. Remove the unused code.
|
|     Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>
Signed-off-by: Roland Hieber <rhi@pengutronix.de>

state: Create alias in of_state_fixup() ...

This ports the following barebox commit:

| commit 70ea799
| Author: Sascha Hauer <s.hauer@pengutronix.de>
| Date:   Thu May 4 12:50:59 2017 +0200
|
|     state: Create alias in of_state_fixup()
|
|     When the kernel device tree is fixed up we assume that it doesn't
|     have a state node, so we must also assume that it doesn't have
|     a alias. Create it.
|
|     Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>
Signed-off-by: Roland Hieber <rhi@pengutronix.de>

state: Make an alias mandatory ...

This ports the following barebox commit:

| commit 4983191
| Author: Sascha Hauer <s.hauer@pengutronix.de>
| Date:   Thu May 4 12:27:21 2017 +0200
|
|     state: Make an alias mandatory
|
|     The userspace barebox-state utility gets confused when no alias exists.
|     Make the alias mandatory, so that people make it right^tm without having
|     to ask.
|
|     Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>
Signed-off-by: Roland Hieber <rhi@pengutronix.de>

state: warn when a state node will be overwritten ...

This ports the following barebox commit:

| commit b30047b
| Author: Sascha Hauer <s.hauer@pengutronix.de>
| Date:   Thu May 4 11:58:23 2017 +0200
|
|     state: warn when a state node will be overwritten
|
|     People do not seem to know that a state node in the kernel
|     device tree will be overwritten by barebox. Print a warning
|     when this happens so that people can get an idea why changes
|     in the kernel device tree state node do not have any effect.
|
|     Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>
Signed-off-by: Roland Hieber <rhi@pengutronix.de>

state: Fix error return value ...

This ports the following barebox commit:

| commit d11584d
| Author: Sascha Hauer <s.hauer@pengutronix.de>
| Date:   Wed Apr 19 14:34:30 2017 +0200
|
|     state: Fix error return value
|
|     When the backend phandle cannot be resolved we jump to the error
|     return path without initializing ret. Fix this.
|
|     Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>
Signed-off-by: Roland Hieber <rhi@pengutronix.de>

state: find device node from device path, not from device node path ...

This adds a dummy version of of_find_node_by_devpath() to make the linker happy
and ports the following barebox commit:

| commit e627903
| Author: Sascha Hauer <s.hauer@pengutronix.de>
| Date:   Thu Mar 30 16:33:26 2017 +0200
|
|     state: find device node from device path, not from device node path
|
|     The device node path may change from the internal device tree to the
|     one Linux is started with, so using this path to fixup the tree is
|     not very robust. Instead, use of_find_node_by_devpath() which has
|     been created for exactly this purpose.
|
|     Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>
Signed-off-by: Roland Hieber <rhi@pengutronix.de>

state: Make pointing to the backend using a phandle the only supported method ...

This ports the following barebox commit and removes the now no longer used noop
definition of of_find_path():

| commit 99020ca
| Author: Sascha Hauer <s.hauer@pengutronix.de>
| Date:   Tue Mar 21 13:57:51 2017 +0100
|
|     state: Make pointing to the backend using a phandle the only supported method
|
|     All other methods are broken for some time already: When starting the
|     kernel the state code rewrites the state node in the device tree and
|     replaced the "backend" property with a phandle - even when the target
|     can't be described as a phandle. Since using phandles is the nicest way
|     to point to the storage device anyway remove the other methods.
|
|     Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>
Signed-off-by: Roland Hieber <rhi@pengutronix.de>

treewide: Use of_property_write_string() where appropriate ...

This ports the following barebox commit:

| commit b608918
| Author: Sascha Hauer <s.hauer@pengutronix.de>
| Date:   Thu Mar 30 10:38:19 2017 +0200
|
|     treewide: Use of_property_write_string() where appropriate
|
|     Replace users which use of_set_property() to set a property to a string
|     with of_property_write_string().
|
|     Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>
Signed-off-by: Roland Hieber <rhi@pengutronix.de>

state: Do not load state during state_new_from_node ...

The caller of state_new_from_node() may have it's own ideas what to
do when loading the state fails, so do not load it in the initialization
function, but instead let the caller do it.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

state: Allow to load without authentification ...

Sometimes it's useful to be able to load a state even when it
can't be authentificated. Add an option for this.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

state: Convert all bufs to void * ...

A void * is a much better type for a buffer than a u8 * as it
can be casted to any other type implicitly. Convert all buffers
used by the state framework to void *.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

state: pass struct state * to storage functions ...

We can get a state_backend_storage * and the device * from struct state,
so pass this to the storage functions rather than the two pointers.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

state: remove unnecessary argument from state_format_init ...

The device pointer is already in struct state, no need to pass it
around when a struct state * is already passed.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

state: open code state_backend_init in caller ...

Safes a lot of argument passing to a function that is used
only once.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

state: merge backend.c into state.c ...

The code in backend.c is too small to justify an extra file. Merge it
into state.c.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

state: Drop backend as extra struct type ...

struct state_backend is embedded into struct state. This additional
indirection does not have any real gain. Drop it.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

state: pass error code instead of inventing new one ...

Both of_find_path() and of_find_path_by_node() return a meaningful
error code, so forward it instead of inventing a new one. Do this
especially for the -EPROBE_DEFER case which currently does not work.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

state: fix finding the correct parent node ...

Looking for the parent node during fixup is broken. The path of the parent
node is not correctly terminated ('0' vs '\0'). Also, the new state node
should be added to the supplied device tree not the barebox device tree
used by of_find_node_by_path().

Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

barebox-state: Sync pieces with barebox ...

dev_add_param_bool are no-ops, save_on_shutdown is irrelevant for the
userspace part. Sync with barebox as of v2017.03.0

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

state: don't keep pointers to device tree nodes ...

Caching pointers to device tree nodes or is not save. The barebox internal
device tree may be changed by loading a new device tree or through fixup
handlers. As a result, the node may be deleted and replaced with a new one.
Keep a copy of the full path instead and resolve the node as needed.

Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

Revert "barebox-state: Add force switch" ...

This reverts commit 89135e5.

barebox-state: Add force switch ...

The force switch allows to read from a state even when the
keystore blobs cannot be read.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>