barebox-state: remove unused variables ...

By cleaning up the code the compiler does not emit the following warning
anymore:

    src/barebox-state.c: In function '__state_string_get':
    src/barebox-state.c:254:6: warning: unused variable 'ret' [-Wunused-variable]
      int ret;
          ^~~
    src/barebox-state.c: In function 'state_get':
    src/barebox-state.c:317:25: warning: unused variable 'v' [-Wunused-variable]
      struct state_variable *v;
                             ^
    src/barebox-state.c:316:14: warning: unused variable 'backend_type' [-Wunused-variable]
      const char *backend_type = NULL;
                  ^~~~~~~~~~~~
    src/barebox-state.c:313:8: warning: unused variable 'path' [-Wunused-variable]
      char *path;
            ^~~~
    src/barebox-state.c: In function 'main':
    src/barebox-state.c:561:9: warning: unused variable 'i' [-Wunused-variable]
         int i;
             ^

Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>
Signed-off-by: Roland Hieber <rhi@pengutronix.de>

barebox-state: remove declaration of __state_uint8_get() ...

By cleaning up the code the compiler does not emit the following warning
anymore:

    src/barebox-state.c:44:14: warning: ‘__state_uint8_get’ declared ‘static’ but never defined [-Wunused-function]
     static char *__state_uint8_get(struct state_variable *var);
                  ^~~~~~~~~~~~~~~~~

The function is not needed as its job is done by __state_uint32_get().

Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>
Signed-off-by: Roland Hieber <rhi@pengutronix.de>

barebox-state: add cmdline option "--version" ...

Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>
Signed-off-by: Roland Hieber <rhi@pengutronix.de>

barebox-state: complete cmdline options ...

Make the commandline options consistent and complete:

  - option "-h" already had a long equivalent "--help", so reflect that in the
    usage() message.
  - for option "-q" the usage() message promised a long equivalent "--quiet"
    that did not exist.
  - the call to getopt_long() already allowed the option "-f" in its optstring,
    but the usage() message said nothing about it, hence amend that and offer
    the long option "--force" as well.

Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>
Signed-off-by: Roland Hieber <rhi@pengutronix.de>

barebox-state: fix usage of multiple state instances ...

Let's assume there are two state instances named "blue" (with variable "x") and
"yellow" (with variable "y") then

  $ barebox-state --name blue --get x
  $ barebox-state --name yellow --get y

would both work, whereas only exactly one of the alternative calls

  $ barebox-state --get blue.x
  $ barebox-state --get yellow.y

would succeed. This commit fixes that bug.

Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>
Signed-off-by: Roland Hieber <rhi@pengutronix.de>

barebox-state: fix error message ...

Negative errnos result into "Unknown error -22" instead of "Invalid
argument". The latter is more helpful, while the first is mostly useless.

Signed-off-by: Juergen Borleis <jbe@pengutronix.de>

state: remove unused arguments from state_new_from_node() ...

Other than in barebox the offset and size of a state's backend device do not
necessarily equal zero in Linux userspace (EEPROMs & block devices). So we have
to consider that and differentiate between both usecases here while porting the
following barebox commit and removing the now no longer used noop definition of
of_find_path_by_node():

| commit a66a8d7
| Author: Sascha Hauer <s.hauer@pengutronix.de>
| Date:   Tue Feb 20 12:21:00 2018 +0100
|
|     state: remove unused arguments from state_new_from_node()
|
|     state_new_from_node() has arguments describing the backend path. These
|     are never used in barebox, the backend path is always derived from the
|     device nodes backend description. Remove these arguments.
|
|     Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>
[rhi: fixed tabs vs. spaces indentation in state_new_from_node()]
Signed-off-by: Roland Hieber <rhi@pengutronix.de>

state: refactor variable type ...

This ports the following barebox commits and adjusts the handling of type
information of state variables in barebox-state:

| commit 7b3d284
| Author: Sascha Hauer <s.hauer@pengutronix.de>
| Date:   Mon Apr 3 22:51:58 2017 +0200
|
|     state: remove unused variable type
|
|     enum state_variable_type is never used. Remove it.
|
|     Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

| commit 7126dff
| Author: Daniel Schultz <d.schultz@phytec.de>
| Date:   Fri Nov 3 11:48:26 2017 +0100
|
|     common: state: Add variable_type to state_variable
|
|     Add a pointer in state_variable to the corresponding variable_type array
|     element.
|
|     Signed-off-by: Daniel Schultz <d.schultz@phytec.de>
|     Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

| commit dc74265
| Author: Daniel Schultz <d.schultz@phytec.de>
| Date:   Fri Nov 3 11:48:27 2017 +0100
|
|     common: state: Add variable type as enum
|
|     The variable_type struct holds a name of its type. Checking the type of
|     a variable with this string needs much resources.
|
|     This patch introduce a enum of the variable type for better type
|     checking.
|
|     Signed-off-by: Daniel Schultz <d.schultz@phytec.de>
|     Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>
[rhi: fixed function parameter alignment in common/state/state_variables.c,
  and submitted those changes as patches for barebox:
  https://www.mail-archive.com/barebox@lists.infradead.org/msg29427.html
  https://www.mail-archive.com/barebox@lists.infradead.org/msg29462.html ]
Signed-off-by: Roland Hieber <rhi@pengutronix.de>

barebox-state: block while waiting for file lock ...

In multi-processes environment, it can happen that barebox-state is
called concurrently. Since barebox-state usually only runs for at most a
few seconds, it is probably okay for the second process to block while
wait for the file lock, so the calling entity (user or script) doesn't
have to do error handling itself.

Signed-off-by: Roland Hieber <r.hieber@pengutronix.de>

barebox-state: Fail for unhandled arguments ...

When passing unhandled arguments as in

  % barebox-state foo

these will be silently ignored. This may lead to misunderstandings and
unintended behavior, thus the user should be informed and the programm
should exit with an error in these cases.

Signed-off-by: Enrico Jorns <ejo@pengutronix.de>
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

barebox-state: fix termination of long_options[] ...

From the getopt_long() documentation:

| The argument longopts must be an array of these structures, one for each
| long option. Terminate the array with an element containing all zeros.

Otherwise barebox-state will segfault for unknown options:

  % ./barebox-state --foo
  [1]    17946 segmentation fault (core dumped)  ./barebox-state --foo

Signed-off-by: Enrico Jorns <ejo@pengutronix.de>
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

barebox-state: implement skipping authentification (again) ...

Implement authentification again, this time wihtout the need of
passing a "force" argument through half of the function call stack.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

state: Do not load state during state_new_from_node ...

The caller of state_new_from_node() may have it's own ideas what to
do when loading the state fails, so do not load it in the initialization
function, but instead let the caller do it.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

barebox-state: make state_get() definition consistent to its prototype ...

In 2839d4f6f4 state_get() got an additional argument, but its prototype
in barebox-state.h was never adjusted. Include the file containing
the prototype from the file containing the function definition so that
this bug can be detected by the compiler. Also add the missing argument
to the callers.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

Revert "barebox-state: Add force switch" ...

This reverts commit 89135e5.

barebox-state: Add force switch ...

The force switch allows to read from a state even when the
keystore blobs cannot be read.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

rework logging functions ...

We already use pr_* and dev_* functions. Replace some more
fprintf(stderr,...) with appropriate pr_* function calls. Also
provide control over which urgency level is printed.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

barebox-state: fix typo ...

Signed-off-by: Bastian Stender <bst@pengutronix.de>

barebox-state: only set state->name by state->state if valid ...

This patch fixes commit d4c997a3.

Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de>

barebox-state: make sure state->name is valid ...

It's used later while setting state variables.

Fixes: feb64890a302 ("barebox-state: fall back to /state if there is no alias defined")
Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>

barebox-state: fall back to /state if there is no alias defined ...

state_get() already supports this if no state name is given. This just
removes the default state name to make use of this feature.

Without this, an alias named 'state' is needed for barebox-state work
without specifying the state node.

Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>

barebox-state: return non-zero exit code for missing or invalid arg ...

This make barebox-state return non-zero exit-code in case of a missing
parameter (':') or an invalid/unknown argument ('?').
No extra printing of error messages is performed as this is handled by
getopt itself in this configuration.

Signed-off-by: Enrico Jorns <ejo@pengutronix.de>
Tested-by: Bastian Stender <bst@pengutronix.de>

barebox-state: fix print variable on --get ...

676e2a1 accidentally
removed the printf call.

Signed-off-by: Bastian Stender <bst@pengutronix.de>

barebox-state: Fix prefix removal of variables ...

Signed-off-by: Markus Pargmann <mpa@pengutronix.de>

barebox-state: Fix default state ...

Signed-off-by: Markus Pargmann <mpa@pengutronix.de>

barebox-state: Add possibility to specify multiple state names ...

Signed-off-by: Markus Pargmann <mpa@pengutronix.de>

Update barebox-state ...

Fixed direct bucket

Signed-off-by: Markus Pargmann <mpa@pengutronix.de>

barebox-state: Add locking file ...

Signed-off-by: Markus Pargmann <mpa@pengutronix.de>

barebox-state: Import updated state code ...

Signed-off-by: Markus Pargmann <mpa@pengutronix.de>

barebox-state: make state_get() state_get_var() non static ...

Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>