Ensure the flow through switch statements is clear
Ensure case clauses:
*   Terminate with an unconditional break, return or goto statement.
*   Use conditional break, return or goto statements as long as the end
    of the case clause is unreachable; such case clauses must terminate
    with assert(0) /* Unreachable */ or an unconditional  __dead2 function
    call
*   Only fallthough when doing otherwise would result in less
    readable/maintainable code; such case clauses must terminate with a
    /* Fallthrough */ comment to make it clear this is the case and
    indicate that a fallthrough is intended.

This reduces the chance of bugs appearing due to unintended flow through a
switch statement

Change-Id: I70fc2d1f4fd679042397dec12fd1982976646168
Signed-off-by: Daniel Boulby <daniel.boulby@arm.com>
1 parent e52ed09 commit a08a2014300a495381cdb8f6d59523bcd5d3b883
@Daniel Boulby Daniel Boulby authored on 22 Jun 2018
Showing 9 changed files
View
bl1/bl1_fwu.c
View
lib/libc/printf.c
View
lib/libc/snprintf.c
View
plat/common/plat_gicv2.c
View
plat/common/plat_gicv3.c
View
plat/rockchip/rk3399/drivers/dp/cdn_dp.c
View
plat/xilinx/zynqmp/pm_service/pm_api_ioctl.c
View
services/spd/tlkd/tlkd_common.c
View
services/spd/tspd/tspd_main.c