LuminaSensum/arm-trusted-firmware

Fork: 0

LuminaSensum / arm-trusted-firmware

2017-01-30	10bcd76 Browse files » Report errata workaround status to console ... The errata reporting policy is as follows: - If an errata workaround is enabled: - If it applies (i.e. the CPU is affected by the errata), an INFO message is printed, confirming that the errata workaround has been applied. - If it does not apply, a VERBOSE message is printed, confirming that the errata workaround has been skipped. - If an errata workaround is not enabled, but would have applied had it been, a WARN message is printed, alerting that errata workaround is missing. The CPU errata messages are printed by both BL1 (primary CPU only) and runtime firmware on debug builds, once for each CPU/errata combination. Relevant output from Juno r1 console when ARM Trusted Firmware is built with PLAT=juno LOG_LEVEL=50 DEBUG=1: VERBOSE: BL1: cortex_a57: errata workaround for 806969 was not applied VERBOSE: BL1: cortex_a57: errata workaround for 813420 was not applied INFO: BL1: cortex_a57: errata workaround for disable_ldnp_overread was applied WARNING: BL1: cortex_a57: errata workaround for 826974 was missing! WARNING: BL1: cortex_a57: errata workaround for 826977 was missing! WARNING: BL1: cortex_a57: errata workaround for 828024 was missing! WARNING: BL1: cortex_a57: errata workaround for 829520 was missing! WARNING: BL1: cortex_a57: errata workaround for 833471 was missing! ... VERBOSE: BL31: cortex_a57: errata workaround for 806969 was not applied VERBOSE: BL31: cortex_a57: errata workaround for 813420 was not applied INFO: BL31: cortex_a57: errata workaround for disable_ldnp_overread was applied WARNING: BL31: cortex_a57: errata workaround for 826974 was missing! WARNING: BL31: cortex_a57: errata workaround for 826977 was missing! WARNING: BL31: cortex_a57: errata workaround for 828024 was missing! WARNING: BL31: cortex_a57: errata workaround for 829520 was missing! WARNING: BL31: cortex_a57: errata workaround for 833471 was missing! ... VERBOSE: BL31: cortex_a53: errata workaround for 826319 was not applied INFO: BL31: cortex_a53: errata workaround for disable_non_temporal_hint was applied Also update documentation. Change-Id: Iccf059d3348adb876ca121cdf5207bdbbacf2aba Signed-off-by: Jeenu Viswambharan <jeenu.viswambharan@arm.com> Jeenu Viswambharan committed on 30 Jan 2017
2017-01-30	b38bc68 Browse files » Allow spin locks to be defined from assembly ... At present, spin locks can only defined from C files. Add some macros such that they can be defined from assembly files too. Change-Id: I64f0c214062f5c15b3c8b412c7f25c908e87d970 Signed-off-by: Jeenu Viswambharan <jeenu.viswambharan@arm.com> Jeenu Viswambharan committed on 30 Jan 2017
2017-01-24	d7aa7b4 Browse files » Merge pull request #817 from antonio-nino-diaz-arm/an/timingsafe ... Import constant-time bcmp() and use it where necessary danh-arm authored on 24 Jan 2017 GitHub committed on 24 Jan 2017
	b621fb5 Browse files » tbbr: Use constant-time bcmp() to compare hashes ... To avoid timing side-channel attacks, it is needed to use a constant time memory comparison function when comparing hashes. The affected code only cheks for equality so it isn't needed to use any variant of memcmp(), bcmp() is enough. Also, timingsafe_bcmp() is as fast as memcmp() when the two compared regions are equal, so this change incurrs no performance hit in said case. In case they are unequal, the boot sequence wouldn't continue as normal, so performance is not an issue. Change-Id: I1c7c70ddfa4438e6031c8814411fef79fd3bb4df Signed-off-by: Antonio Nino Diaz <antonio.ninodiaz@arm.com> Antonio Nino Diaz committed on 24 Jan 2017
	aa050a7 Browse files » stdlib: Import timingsafe_bcmp() from FreeBSD ... Some side-channel attacks involve an attacker inferring something from the time taken for a memory compare operation to complete, for example when comparing hashes during image authentication. To mitigate this, timingsafe_bcmp() must be used for such operations instead of the standard memcmp(). This function executes in constant time and so doesn't leak any timing information to the caller. Change-Id: I470a723dc3626a0ee6d5e3f7fd48d0a57b8aa5fd Signed-off-by: dp-arm <dimitris.papastamos@arm.com> Signed-off-by: Antonio Nino Diaz <antonio.ninodiaz@arm.com> Antonio Nino Diaz committed on 24 Jan 2017
	3443866 Browse files » Merge pull request #818 from sandrine-bailleux-arm/sb/strnlen ... Add strnlen() to local C library danh-arm authored on 24 Jan 2017 GitHub committed on 24 Jan 2017
	d67879d Browse files » Add strnlen() to local C library ... This code has been imported and slightly adapted from FreeBSD: https://github.com/freebsd/freebsd/blob/6253393ad8df55730481bf2aafd76bdd6182e2f5/lib/libc/string/strnlen.c Change-Id: Ie5ef5f92e6e904adb88f8628077fdf1d27470eb3 Signed-off-by: Sandrine Bailleux <sandrine.bailleux@arm.com> Sandrine Bailleux committed on 24 Jan 2017
2017-01-23	4abd222 Browse files » Merge pull request #800 from masahir0y/ifdef ... Correct preprocessor conditionals danh-arm authored on 23 Jan 2017 GitHub committed on 23 Jan 2017
	e02be20 Browse files » Merge pull request #815 from hzhuang1/dwmmc_v3.9 ... drivers: add designware emmc driver danh-arm authored on 23 Jan 2017 GitHub committed on 23 Jan 2017
	6af03f9 Browse files » Use #ifdef for AARCH32 instead of #if ... One nasty part of ATF is some of boolean macros are always defined as 1 or 0, and the rest of them are only defined under certain conditions. For the former group, "#if FOO" or "#if !FOO" must be used because "#ifdef FOO" is always true. (Options passed by $(call add_define,) are the cases.) For the latter, "#ifdef FOO" or "#ifndef FOO" should be used because checking the value of an undefined macro is strange. For AARCH32/AARCH64, these macros are defined in the top-level Makefile as follows: ifeq (${ARCH},aarch32) $(eval $(call add_define,AARCH32)) else $(eval $(call add_define,AARCH64)) endif This means only one of the two is defined. So, AARCH32/AARCH64 belongs to the latter group where we should use #ifdef or #ifndef. The conditionals are mostly coded correctly, but I see some mistakes. Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> Masahiro Yamada committed on 23 Jan 2017
	3d8256b Browse files » Use #ifdef for IMAGE_BL* instead of #if ... One nasty part of ATF is some of boolean macros are always defined as 1 or 0, and the rest of them are only defined under certain conditions. For the former group, "#if FOO" or "#if !FOO" must be used because "#ifdef FOO" is always true. (Options passed by $(call add_define,) are the cases.) For the latter, "#ifdef FOO" or "#ifndef FOO" should be used because checking the value of an undefined macro is strange. Here, IMAGE_BL* is handled by make_helpers/build_macro.mk like follows: $(eval IMAGE := IMAGE_BL$(call uppercase,$(3))) $(OBJ): $(2) @echo " CC $$<" $$(Q)$$(CC) $$(TF_CFLAGS) $$(CFLAGS) -D$(IMAGE) -c $$< -o $$@ This means, IMAGE_BL* is defined when building the corresponding image, but undefined for the other images. So, IMAGE_BL* belongs to the latter group where we should use #ifdef or #ifndef. Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> Masahiro Yamada committed on 23 Jan 2017
	7750990 Browse files » Merge pull request #808 from masahir0y/build_fix ... Fix parallel building danh-arm authored on 23 Jan 2017 GitHub committed on 23 Jan 2017
	5dbdb7d Browse files » drivers: add designware emmc driver ... Support Designware eMMC driver. It's based on both IO block and eMMC driver. Signed-off-by: Haojian Zhuang <haojian.zhuang@linaro.org> Haojian Zhuang committed on 23 Jan 2017
	bf6363a Browse files » Merge pull request #810 from masahir0y/fiptool_fix ... Fix fiptool bug introduced by recent rework danh-arm authored on 23 Jan 2017 GitHub committed on 23 Jan 2017
	7b94e4b Browse files » Merge pull request #813 from antonio-nino-diaz-arm/an/libfdt ... Update libfdt to version 1.4.2 danh-arm authored on 23 Jan 2017 GitHub committed on 23 Jan 2017
	23beccc Browse files » Merge pull request #812 from antonio-nino-diaz-arm/an/clear-static-vars ... Clear static variables in X509 parser on error danh-arm authored on 23 Jan 2017 GitHub committed on 23 Jan 2017
2017-01-19	d014ea6 Browse files » Build: strip trailing slashes from directory paths more simply ... Append . then strip /. seems clumsy. Just use $(patsubst %/,%, ). Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> Masahiro Yamada committed on 19 Jan 2017
	a6ca788 Browse files » Build: Fix parallel building ... Soren reports build fails if -j option is given: $ make -j16 CROSS_COMPILE=aarch64-linux-gnu- Building fvp make: * No rule to make target 'build/fvp/release/bl1/', needed by 'build/fvp/release/bl1/bl1.ld'. Stop. make: * Waiting for unfinished jobs.... The cause of the failure is that $(dir ) leaves a trailing / on the directory names. It must be ripped off to let Make create the directory. There are some ways to fix the issue. Here, I chose to make MAKE_LD look like MAKE_C and MAKE_S because bl*_dirs seems the central place of making directories. Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> Reported-by: Soren Brinkmann <soren.brinkmann@xilinx.com> Tested-by: Soren Brinkmann <soren.brinkmann@xilinx.com> Masahiro Yamada committed on 19 Jan 2017
	51c5e1a Browse files » Clear static variables in X509 parser on error ... In mbedtls_x509_parser.c there are some static arrays that are filled during the integrity check and then read whenever an authentication parameter is requested. However, they aren't cleared in case of an integrity check failure, which can be problematic from a security point of view. This patch clears these arrays in the case of failure. Change-Id: I9d48f5bc71fa13e5a75d6c45b5e34796ef13aaa2 Signed-off-by: Antonio Nino Diaz <antonio.ninodiaz@arm.com> Antonio Nino Diaz committed on 19 Jan 2017
	c8d64c5 Browse files » Fix declarations of cache maintenance functions ... Fix the parameter type of the maintenance functions of data cache. Add missing declarations for AArch32 versions of dcsw_op_louis and dcsw_op_all to match the AAch64 ones. Change-Id: I4226e8ea4f8b2b5bc2972992c83de659ee0da52c Antonio Nino Diaz committed on 19 Jan 2017
2017-01-18	f38d93f Browse files » Merge pull request #801 from masahir0y/cleanup ... Macro cleanups davidcunado-arm authored on 18 Jan 2017 GitHub committed on 18 Jan 2017
	faaa945 Browse files » Merge pull request #811 from davidcunado-arm/dc/dc-scratch-pad ... Correct system include order davidcunado-arm authored on 18 Jan 2017 GitHub committed on 18 Jan 2017
	1dd920f Browse files » Merge pull request #809 from paulkocialkowski/integration ... mt8173: Correct SPM MCDI firmware length danh-arm authored on 18 Jan 2017 GitHub committed on 18 Jan 2017
	fc17f61 Browse files » Merge pull request #790 from masahir0y/utils ... add utility macros to utils.h danh-arm authored on 18 Jan 2017 GitHub committed on 18 Jan 2017
	7a2b35d Browse files » qemu: remove unused BL32_SIZE ... I do not see any line that references BL32_SIZE. Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> Masahiro Yamada committed on 18 Jan 2017
	4749705 Browse files » Move BL_COHERENT_RAM_BASE/END defines to common_def.h ... We have lots of duplicated defines (and comment blocks too). Move them to include/plat/common/common_def.h. While we are here, suffix the end address with _END instead of _LIMIT. The _END is a better fit to indicate the linker-derived real end address. Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> Masahiro Yamada committed on 18 Jan 2017
	ecdc898 Browse files » Use _END instead of _LIMIT for linker derived end addresses ... The usage of _LIMIT seems odd here, so rename as follows: BL_CODE_LIMIT --> BL_CODE_END BL_RO_DATA_LIMIT --> BL_RO_DATA_END BL1_CODE_LIMIT --> BL1_CODE_END BL1_RO_DATA_LIMIT --> BL1_RO_DATA_END Basically, we want to use _LIMIT and _END properly as follows: _SIZE + _MAX_SIZE = _LIMIT _SIZE + _SIZE = _END The _LIMIT is generally defined by platform_def.h to indicate the platform-dependent memory constraint. So, its typical usage is ASSERT(. <= BL31_LIMIT, "BL31 image has exceeded its limit.") in a linker script. On the other hand, _END is used to indicate the end address of the compiled image, i.e. we do not know it until the image is linked. Here, all of these macros belong to the latter, so should be suffixed with _END. Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> Masahiro Yamada committed on 18 Jan 2017
2017-01-17	55c70cb Browse files » Correct system include order ... NOTE - this is patch does not address all occurrences of system includes not being in alphabetical order, just this one case. Change-Id: I3cd23702d69b1f60a4a9dd7fd4ae27418f15b7a3 David Cunado committed on 17 Jan 2017
2017-01-16	29440c1 Browse files » libfdt: Replace v1.4.1 by v1.4.2 ... Delete old version of libfdt at lib/libfdt. Move new libfdt API headers to include/lib/libfdt and all other files to lib/libfdt. Change-Id: I32b7888f1f20d62205310e363accbef169ad7b1b Signed-off-by: Antonio Nino Diaz <antonio.ninodiaz@arm.com> Antonio Nino Diaz committed on 16 Jan 2017
2017-01-16	a78676b Browse files » libfdt: Minor changes to enable TF integration ... * Add libfdt.mk helper makefile * Remove unused libfdt files * Minor changes to fdt.h and libfdt.h to make them C99 compliant Adapted from `754d78b`. Change-Id: I0847f1c2e6e11f0c899b0b7ecc522c0ad7de210c Signed-off-by: Antonio Nino Diaz <antonio.ninodiaz@arm.com> Antonio Nino Diaz committed on 16 Jan 2017