LuminaSensum/arm-trusted-firmware

Fork: 0

LuminaSensum / arm-trusted-firmware

2017-02-10	762f1eb Browse files » cert_create: fix memory leak bug caused by key container overwrite ... In the current code, both key_load() and key_create() call key_new() to allocate a key container (and they do not free it even if they fail). If a specific key is not given by the command option, key_load() fails, then key_create() is called. At this point, the key container that has been allocated in key_load() is still alive, and it is overwritten by a new key container created by key_create(). Move the key_new() call to the main() function to make sure it is called just once for each descriptor. While we are here, let's fix one more bug; the error handling code ERROR("Malloc error while loading '%s'\n", keys[i].fn); is wrong because keys[i].fn is NULL pointer unless a specific key is given by the command option. This code could be run in either case. Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> Masahiro Yamada committed on 10 Feb 2017
2017-02-07	bab16f9 Browse files » Merge pull request #831 from masahir0y/zynqmp ... zynqmp: remove RESET_TO_BL31=1 from build instruction danh-arm authored on 7 Feb 2017 GitHub committed on 7 Feb 2017
2017-02-06	7c20268 Browse files » Merge pull request #830 from masahir0y/misc ... gitignore: ignore GNU GLOBAL tag files danh-arm authored on 6 Feb 2017 GitHub committed on 6 Feb 2017
	6135922 Browse files » Merge pull request #827 from dp-arm/dp/pmf-constants ... PMF: Fixup PMF constants danh-arm authored on 6 Feb 2017 GitHub committed on 6 Feb 2017
	4fff02c Browse files » zynqmp: remove RESET_TO_BL31=1 from build instruction ... RESET_TO_BL31=1 is specified by plat/xilinx/zynqmp/platform.mk with "override" directive. So, RESET_TO_BL31=1 is guaranteed without any operation on users' side. Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> Masahiro Yamada committed on 6 Feb 2017
2017-02-02	a53fe69 Browse files » gitignore: ignore GNU GLOBAL tag files ... GNU GLOBAL (https://www.gnu.org/software/global/) is source code tagging system. It creates 4 tag files (GTAGS, GRTAGS, GSYMS and GPATH) for the symbol cross-reference. Ignore them. Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> Masahiro Yamada committed on 2 Feb 2017
2017-02-02	888037e Browse files » PMF: Fixup PMF constants ... `PMF_ARM_TIF_IMPL_ID` should be set to 0x41. The code already left shifts it by 24 bit positions so this was overflowing. This fixes a build error with GCC 6.2 when `ENABLE_RUNTIME_INSTRUMENTATION` is set. Change-Id: I4c99d48ea7ce3d76e9edd1325b1979994db2c0fb Signed-off-by: dp-arm <dimitris.papastamos@arm.com> dp-arm committed on 2 Feb 2017
2017-01-31	bcc2bf0 Browse files » Merge pull request #821 from jeenu-arm/errata-printing ... Errata printing infrastructure danh-arm authored on 31 Jan 2017 GitHub committed on 31 Jan 2017
	474d4ec Browse files » Merge pull request #799 from masahir0y/fiptool ... fiptool: Alignment support + misc refactoring danh-arm authored on 31 Jan 2017 GitHub committed on 31 Jan 2017
	e9ced6f Browse files » Merge pull request #825 from dp-arm/dp/simplify-cond ... tbbr: Simplify conditional danh-arm authored on 31 Jan 2017 GitHub committed on 31 Jan 2017
	bac7529 Browse files » Merge pull request #823 from douglas-raillard-arm/dr/add_fno_builtin ... Add -fno-builtin to CFLAGS danh-arm authored on 31 Jan 2017 GitHub committed on 31 Jan 2017
	f2590d6 Browse files » Merge pull request #822 from jeenu-arm/fix-fvp-refs ... user-guide.md: Fix FVP references danh-arm authored on 31 Jan 2017 GitHub committed on 31 Jan 2017
	424ad49 Browse files » Merge pull request #819 from davidcunado-arm/dc/build_with_gcc6.2 ... Resolve build errors flagged by GCC 6.2 danh-arm authored on 31 Jan 2017 GitHub committed on 31 Jan 2017
	f3ded37 Browse files » tbbr: Simplify conditional ... These are equivalent so use the reduced form. Change-Id: I40ca097411b9abab69985b8e4dbccf7582eae49e Signed-off-by: dp-arm <dimitris.papastamos@arm.com> dp-arm committed on 31 Jan 2017
2017-01-30	10bcd76 Browse files » Report errata workaround status to console ... The errata reporting policy is as follows: - If an errata workaround is enabled: - If it applies (i.e. the CPU is affected by the errata), an INFO message is printed, confirming that the errata workaround has been applied. - If it does not apply, a VERBOSE message is printed, confirming that the errata workaround has been skipped. - If an errata workaround is not enabled, but would have applied had it been, a WARN message is printed, alerting that errata workaround is missing. The CPU errata messages are printed by both BL1 (primary CPU only) and runtime firmware on debug builds, once for each CPU/errata combination. Relevant output from Juno r1 console when ARM Trusted Firmware is built with PLAT=juno LOG_LEVEL=50 DEBUG=1: VERBOSE: BL1: cortex_a57: errata workaround for 806969 was not applied VERBOSE: BL1: cortex_a57: errata workaround for 813420 was not applied INFO: BL1: cortex_a57: errata workaround for disable_ldnp_overread was applied WARNING: BL1: cortex_a57: errata workaround for 826974 was missing! WARNING: BL1: cortex_a57: errata workaround for 826977 was missing! WARNING: BL1: cortex_a57: errata workaround for 828024 was missing! WARNING: BL1: cortex_a57: errata workaround for 829520 was missing! WARNING: BL1: cortex_a57: errata workaround for 833471 was missing! ... VERBOSE: BL31: cortex_a57: errata workaround for 806969 was not applied VERBOSE: BL31: cortex_a57: errata workaround for 813420 was not applied INFO: BL31: cortex_a57: errata workaround for disable_ldnp_overread was applied WARNING: BL31: cortex_a57: errata workaround for 826974 was missing! WARNING: BL31: cortex_a57: errata workaround for 826977 was missing! WARNING: BL31: cortex_a57: errata workaround for 828024 was missing! WARNING: BL31: cortex_a57: errata workaround for 829520 was missing! WARNING: BL31: cortex_a57: errata workaround for 833471 was missing! ... VERBOSE: BL31: cortex_a53: errata workaround for 826319 was not applied INFO: BL31: cortex_a53: errata workaround for disable_non_temporal_hint was applied Also update documentation. Change-Id: Iccf059d3348adb876ca121cdf5207bdbbacf2aba Signed-off-by: Jeenu Viswambharan <jeenu.viswambharan@arm.com> Jeenu Viswambharan committed on 30 Jan 2017
	b38bc68 Browse files » Allow spin locks to be defined from assembly ... At present, spin locks can only defined from C files. Add some macros such that they can be defined from assembly files too. Change-Id: I64f0c214062f5c15b3c8b412c7f25c908e87d970 Signed-off-by: Jeenu Viswambharan <jeenu.viswambharan@arm.com> Jeenu Viswambharan committed on 30 Jan 2017
	e507f8e Browse files » Add -fno-builtin to CFLAGS ... Disable the automatic substitution of functions with builtins. The existing -ffreestanding option should already do this but explicitly adding -fno-builtin reduces the risk of compiler variation. With this option, GCC is not supposed to be able to make assumptions on what the function does, which could otherwise lead to security-sensitive code removal. This can lead to potentially less efficient code but improves predictability of what code is actually compiled into the binary. Change-Id: I06ad151c61318bd1b00d84976f051d2d94314acc Signed-off-by: Douglas Raillard <douglas.raillard@arm.com> Douglas Raillard committed on 30 Jan 2017
2017-01-28	1c75d5d Browse files » fiptool: support --align option to add desired alignment to image offset ... The current fiptool packs all the images without any padding between them. So, the offset to each image has no alignment. This is not efficient, for example, when the FIP is read from a block-oriented device. For example, (e)MMC is accessed by block-addressing. The block size is 512 byte. So, the best case is each image is aligned by 512 byte since the DMA engine can transfer the whole of the image to its load address directly. The worst case is the offset does not have even DMA-capable alignment (this is where we stand now). In this case, we need to transfer every block to a bounce buffer, then do memcpy() from the bounce buffer to our final destination. At least, this should work with the abstraction by the block I/O layer, but the CPU-intervention for the whole data transfer makes it really slow. This commit adds a new option --align to the fiptool. This option, if given, requests the tool to align each component in the FIP file by the specified byte. Also, add a new Make option FIP_ALIGN for easier access to this feature; users can give something like FIP_ALIGN=512 from the command line, or add "FIP_ALIGN := 512" to their platform.mk file. Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> Masahiro Yamada committed on 28 Jan 2017
2017-01-28	65caa3d Browse files » fiptool: embed fip_toc_entry in struct image ... The struct image has "uuid" and "size" to memorize the field values they had in the TOC entry. So, parse_fip() copies them from struct fip_toc_entry to struct image, then pack_images() copies them back to struct fip_toc_entry. The next commit (support --align option) will require to save the "offset" field as well. This makes me realize that struct image can embed struct fip_toc_entry. This commit will allow the "flags" field to persevere the "update" command. At this moment, the "flags" is not used in a useful way. (Yet, platforms can save their own parameters in the flags field.) It makes sense to save it unless users explicitly replace the image. Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> Masahiro Yamada committed on 28 Jan 2017
2017-01-27	a1da83f Browse files » fiptool: add xfwrite() helper ... We have same patterns for fwrite(). Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> Masahiro Yamada committed on 27 Jan 2017
	4f96a49 Browse files » fiptool: fix the global option in usage ... The global option --verbose should come after the "fiptool". Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> Masahiro Yamada committed on 27 Jan 2017
	ee07932 Browse files » fiptool: simplify the top line of command usage ... We need not mention like [--force], [--out <path>] because they are included in [opts]. Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> Masahiro Yamada committed on 27 Jan 2017
	9e866d3 Browse files » fiptool: refactor remove_image() ... We need not handle the image_head as a special case. Just use a double-pointer to simplify the traverse. Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> Masahiro Yamada committed on 27 Jan 2017
	e9e0d28 Browse files » fiptool: simplify assert() for add_image(_desc) ... lookup_image(_desc)_from_uuid() traverses the linked list, so it is not efficient. We just want to make sure *p points to NULL here. Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> Masahiro Yamada committed on 27 Jan 2017
	ea39d55 Browse files » fiptool: revive replace_image() to keep the image order by update command ... Commit e0f083a09b29 ("fiptool: Prepare ground for expanding the set of images at runtime") introduced another side effect; the "update" command now changes the image order in the FIP. Let's say you have an FIP with BL2, BL31, BL32, BL33. If you update for example, BL32 with the "update" command, you will get a new FIP with BL2, BL31, BL33, BL32, in this order. It happens like this; remove_image() removes the old image from the linked list, add_image() adds the new image at the tail of the list, then images are packed in the new order. Prior to that commit, images were updated by replace_image(), but it was deleted by the re-work. Revive replace_image() that is re-implemented to work with the linked list. Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> Masahiro Yamada committed on 27 Jan 2017
2017-01-26	67973fb Browse files » fiptool: remove always true conditional ... The conditional if (desc != NULL) ... is always true here because we assert it 6 lines above: assert(desc != NULL); Remove the if-conditional and concatenate the printf() calls. Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> Masahiro Yamada committed on 26 Jan 2017
	40866aa Browse files » fiptool: fix existence check of FIP input file for update command ... This line should check the existence of the input file, but it is actually checking the output file. When -o option is given to the "update" command, the outfile is unlikely to exist, then parse_fip() is skipped and an empty FIP file is output. This is wrong behavior. Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> Masahiro Yamada committed on 26 Jan 2017
	c38b36d Browse files » Merge pull request #814 from freedomtan/patches-for-8173-crbook-osi-0110 ... Patches for 8173 crbook danh-arm authored on 26 Jan 2017 GitHub committed on 26 Jan 2017
	186cbd0 Browse files » user-guide.md: Fix FVP references ... The current user guide mentions that Foundation model doesn't support debugger interface. Clarify that all FVPs support --cadi-server option such that a CADI-compliant debugger can connect to and control model execution. Also fix broken URL to FVP home page. Change-Id: Ia14d618a4e0abb4b228eb1616040f9b51fb3f6f9 Signed-off-by: Jeenu Viswambharan <jeenu.viswambharan@arm.com> Jeenu Viswambharan committed on 26 Jan 2017
	9edac04 Browse files » Resolve build errors flagged by GCC 6.2 ... With GCC 6.2 compiler, more C undefined behaviour is being flagged as warnings, which result in build errors in ARM TF build. The specific issue that this patch resolves is the use of (1 << 31), which is predominantly used in case statements, where 1 is represented as a signed int. When shifted to msb the behaviour is undefined. The resolution is to specify 1 as an unsigned int using a convenience macro ULL(). A duplicate macro MAKE_ULL() is replaced. Fixes ARM-software/tf-issues#438 Change-Id: I08e3053bbcf4c022ee2be33a75bd0056da4073e1 Signed-off-by: David Cunado <david.cunado@arm.com> David Cunado committed on 26 Jan 2017