pstore: remove unused goto label ...

Previous refactoring removed jumps to fail_clear. Remove it.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

pstore: fix build by re-resolving botched merge conflict ...

297ac7288 ("pstore: Only capture log messages") removed the pstore console.
v3 of the eventually merged 75a74b5c ("console: fix out-of-bounds read
in dputc(/dev/*, ...)") reinstated part of this code, which broke the
pstore build because the now removed bufsize member had a user
reintroduced in the patch.

Fix this by reverting the offending patch's changes to the pstore code.
It wasn't applicable to begin with.

Fixes: 75a74b5c ("console: fix out-of-bounds read in dputc(/dev/*, ...)")
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

Merge branch 'for-next/misc'

Merge branch 'for-next/ext4'

fs: ubootvarfs: use correct format specifier for pointer diff ...

The difference between two pointers is represented as a ptrdiff_t, use the
correct format specifier when printing to get rid of the following warning
in a 64bit build:

warning: format '%x' expects argument of type 'unsigned int',
but argument 3 has type 'long int' [-Wformat=]

Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

fs: ext4: return NULL instead of 0 ...

ext4fs_get_extent_block() returns a pointer, so return NULL instead of
integer 0.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

fs: ext4: Fix handling of sparse files ...

Adoption of U-Boot commit:

| commit f81db56
| Author: Stefan Brüns <stefan.bruens@rwth-aachen.de>
| Date:   Sat Nov 5 22:17:14 2016 +0100
|
|     ext4: Fix handling of sparse files
|
|     A sparse file may have regions not mapped by any extents, at the start
|     or at the end of the file, or anywhere between, thus not finding a
|     matching extent region is never an error.
|
|     Found by python filesystem tests.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

fs: ext4: remove unnecessarily clever file read ...

ext4fs_read_file() tries to tries to bundle contiguous block reads into
longer reads from the device. In barebox we cache in the block layer
already, so this is unnecessary. Simplify the code by removing the
bundled reads.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

fs: ext4: Fix out of bounds memset ...

When a block we read is a sparse block, we memset the corresponding
output buffer to zero. If that block is the last block we read, we
may not memset the whole block, but only up to the length of the output
buffer, which may be shorter than a full block.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

fs: devfs-core: do a case-insensitive compare of partuuids ...

partuuids are represented as hexadecimal strings, where case doesn't
matter. barebox formats them as lower case internally, forcing the
partuuid device tree property to be lower case too. Use strcasecmp to
be case-insensitive.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

efi: use efi_guidcmp helper where appropriate ...

We have a helper for it. Let's use it.

Signed-off-by: Ahmad Fatoum <ahmad@a3f.at>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

fs: devfs-core: have device_find_partition search symlinks ...

The barebox,environment binding documentation notes following for
the device-path property's second string:
> <partname> can be the label for MTD partitions, the number for DOS
> partitions (beginning with 0) or the name for GPT partitions.

This doesn't work currently because the named partitions are realized as
symlinks and those aren't searched by device_find_partition.

Fix this by having symlinks feature an appropriate partname if the cdev
they link at has one and then have device_find_partition search those as
well.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

chdir(): add LOOKUP_DIRECTORY flag to filename_lookup() ...

This makes sure that automount points get handled even if the path
doesn't end with a '/'.

Signed-off-by: Robert Karszniewicz <r.karszniewicz@phytec.de>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

trivial: fix typo lenght -> length ...

Generated by

	perl -p -i -e 's/lenghte?/length/' arch/arm/boards/chumby_falconwing/falconwing.c arch/arm/mach-samsung/mem-s3c64xx.c fs/ext4/ext_common.h lib/gui/lodepng.c include/jtag.h

There is another instance in dts/Bindings/usb/s3c2410-usb.txt, this is
fixed in Linux v5.3-rc1 so supposed to be fixed soon in barebox, too.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

Merge branch 'for-next/tftp'

Merge branch 'for-next/misc'

fs: nfs: Fix possible buffer overflow ...

nfs_readlink_req() interprets a 32bit value directly received from the
network as length argument to memcpy() without any boundary checking.
Clamp the copy size at the end of the incoming packet.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

console: fix out-of-bounds read in dputc(/dev/*, ...) ...

Trying to output a single character via
	echo -a /dev/serial0-1
currently results in garbage output after the newline, because console.c's
fops_write discards the buffer length and passes the buffer to
(struct cdev)::puts which only handles NUL-terminated strings.

Fix this by amending (struct cdev)::puts with a new nbytes parameter,
which is correctly propagated. All this functions now return at most the
nbytes parameter they were passed in. This fixes __console_puts, which
used to count new lines twice in its return value.

Fixes: b4f55fcf35 ("console: expose consoles in devfs")
Cc: Bastian Krause <bst@pengutronix.de>
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

fs: omap4_usbbootfs: remove commented out code ...

The code has been sitting commented out in version control for close
to 7 years now, drop it.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

fs: fat: fix use of wrong enumeration type ...

disk_read returns a DRESULT, not enum filetype. Change the return value
appropriately.

Signed-off-by: Ahmad Fatoum <ahmad@a3f.at>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

fs: tftp: don't maintain tftp dentries in dcache ...

Currently a negative dentry is cached whenever a non-existing file was
looked up over TFTP. Short of a barebox reset, there is no way to
invalidate that dentry, so barebox retries the look up.

Fix this by always reporting TFTP dentries as invalid in the d_revalidate
callback.

Signed-off-by: Ahmad Fatoum <ahmad@a3f.at>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

fs: provide no_revalidate_d_ops for network file systems ...

Networked file systems may wish to forego dentry caching altogether, so
every lookup goes over the network and stale data is avoided.
Provide a no_revalidate_d_ops helper object that does this.

Signed-off-by: Ahmad Fatoum <ahmad@a3f.at>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

fs: tftp: remove duplicate header ...

<fs.h> is included again a few lines prior. Delete it here.

Signed-off-by: Ahmad Fatoum <ahmad@a3f.at>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

Merge branch 'for-next/pstore'

pstore: remove unused code ...

pstore_info->write() is unused, remove the code implementing it.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

pstore: Only capture log messages ...

With this pstore only captures barebox log messages printed with pr_*
and dev_*, but no longer anything printed with printf and friends.

When capturing the barebox output with pstore only the log messages are
of interest, but not the ones printed with printf and certainly not
the things typed interactively on the command line. These are logged
currently because we register pstore as a barebox console. Instead, hook
into pr_puts which only outputs the barebox log messages.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

fs: Add a driver to access U-Boot environment variables ...

Add a driver working on top of ubootvar device and exposing U-Boot
environment variable data as files.

Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
Signed-off-by: Cory Tusar <cory.tusar@zii.aero>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

Merge branch 'for-next/ubifs'

fs: nfs: ensure rpc_req message is send ...

Currently we send a rpc message without checking if the send was
succesful and poll for a answer from the server. If the server didn't
answer within the NFS_TIMEOUT window we send the package again. In case
the package send wasn't successful we always run in that timeout. This
gets even worse if the package send fails more than one time.

Check if the package send was successful and resend the package if it
wasn't to fix this behaviour.

Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

fs: ubifs: Add authentication support ...

This adds UBIFS authentication support. For now, we do not do
any authentication even on authenticated UBIFS images. Since
this behaviour is not what the user normally expects when mounting
authenticated images we only do this when the user explicitly allows
it in "global.ubifs.allow_authenticated_unauthenticated". If the
flag is false then we refuse mounting such an image and return -EPERM
instead.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>