state: fix formatting of "off_t" variables ...

Explicitely casting an "off_t" variable to "long long" and formatting it via
"%lld" or "%llx" respectively makes 32- as well as 64-bit compilers
happy (tested with gcc-8.2.1 and clang-7.0.1).

Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>
Signed-off-by: Roland Hieber <rhi@pengutronix.de>

base64: remove duplicate ‘const’ declaration specifier ...

By cleaning up the code the compiler does not emit the following warning
anymore:

    src/base64.c:15:19: warning: duplicate ‘const’ declaration specifier [-Wduplicate-decl-specifier]
     static const char const uuenc_tbl_base64[65 + 1] = {
                       ^~~~~

Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>
Signed-off-by: Roland Hieber <rhi@pengutronix.de>

base64: remove unused variable ...

The variable seems to be a leftover from importing the function from
busybox-1.23.2 and by cleaning up the code the compiler does not emit the
following warning anymore:

    src/base64.c:34:14: warning: variable ‘src_tail’ set but not used [-Wunused-but-set-variable]
      const char *src_tail;
                  ^~~~~~~~

Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>
Signed-off-by: Roland Hieber <rhi@pengutronix.de>

keystore-blob: remove unused variable ...

By cleaning up the code the compiler does not emit the following warning
anymore:

    src/keystore-blob.c: In function 'keystore_get_secret':
    src/keystore-blob.c:25:15: warning: unused variable 'modifier' [-Wunused-variable]
      char *blob, *modifier, *payload;
                   ^~~~~~~~

Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>
Signed-off-by: Roland Hieber <rhi@pengutronix.de>

barebox-state: remove unused variables ...

By cleaning up the code the compiler does not emit the following warning
anymore:

    src/barebox-state.c: In function '__state_string_get':
    src/barebox-state.c:254:6: warning: unused variable 'ret' [-Wunused-variable]
      int ret;
          ^~~
    src/barebox-state.c: In function 'state_get':
    src/barebox-state.c:317:25: warning: unused variable 'v' [-Wunused-variable]
      struct state_variable *v;
                             ^
    src/barebox-state.c:316:14: warning: unused variable 'backend_type' [-Wunused-variable]
      const char *backend_type = NULL;
                  ^~~~~~~~~~~~
    src/barebox-state.c:313:8: warning: unused variable 'path' [-Wunused-variable]
      char *path;
            ^~~~
    src/barebox-state.c: In function 'main':
    src/barebox-state.c:561:9: warning: unused variable 'i' [-Wunused-variable]
         int i;
             ^

Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>
Signed-off-by: Roland Hieber <rhi@pengutronix.de>

barebox-state: remove declaration of __state_uint8_get() ...

By cleaning up the code the compiler does not emit the following warning
anymore:

    src/barebox-state.c:44:14: warning: ‘__state_uint8_get’ declared ‘static’ but never defined [-Wunused-function]
     static char *__state_uint8_get(struct state_variable *var);
                  ^~~~~~~~~~~~~~~~~

The function is not needed as its job is done by __state_uint32_get().

Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>
Signed-off-by: Roland Hieber <rhi@pengutronix.de>

barebox-state: add cmdline option "--version" ...

Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>
Signed-off-by: Roland Hieber <rhi@pengutronix.de>

barebox-state: complete cmdline options ...

Make the commandline options consistent and complete:

  - option "-h" already had a long equivalent "--help", so reflect that in the
    usage() message.
  - for option "-q" the usage() message promised a long equivalent "--quiet"
    that did not exist.
  - the call to getopt_long() already allowed the option "-f" in its optstring,
    but the usage() message said nothing about it, hence amend that and offer
    the long option "--force" as well.

Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>
Signed-off-by: Roland Hieber <rhi@pengutronix.de>

barebox-state: fix usage of multiple state instances ...

Let's assume there are two state instances named "blue" (with variable "x") and
"yellow" (with variable "y") then

  $ barebox-state --name blue --get x
  $ barebox-state --name yellow --get y

would both work, whereas only exactly one of the alternative calls

  $ barebox-state --get blue.x
  $ barebox-state --get yellow.y

would succeed. This commit fixes that bug.

Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>
Signed-off-by: Roland Hieber <rhi@pengutronix.de>

of_get_devicepath: again correct comment ...

The cited patch went mainline meanwhile so reflect that in the comment.

Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>
Signed-off-by: Roland Hieber <rhi@pengutronix.de>

common: align declarations of dev_add_param_*() functions with barebox ...

The only remaining difference is the argument "value" in dev_add_param_enum()
which is of type int* in barebox and got type uint32_t* here to not let the
compiler warn about assignment of pointers of different signedness.

There is no such warning when compiling barebox as it's applying the compiler
option "-Wno-pointer-sign" in its main makefile.

Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>
Signed-off-by: Roland Hieber <rhi@pengutronix.de>

state: fix typo ...

This ports the following barebox commit:

| commit 69b16bc
| Author: Ulrich Ölmann <u.oelmann@pengutronix.de>
| Date:   Wed Feb 6 11:34:02 2019 +0100
|
|     common: state: fix typo
|
|     Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>
|     Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
|
| M       common/state/backend_format_raw.c
| M       common/state/state.c
| M       common/state/state.h

Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>
Signed-off-by: Roland Hieber <rhi@pengutronix.de>

barebox-state: fix error message ...

Negative errnos result into "Unknown error -22" instead of "Invalid
argument". The latter is more helpful, while the first is mostly useless.

Signed-off-by: Juergen Borleis <jbe@pengutronix.de>

Release 2019.01.0 ...

Signed-off-by: Roland Hieber <rhi@pengutronix.de>

fix leaks of memory returned by read_file() calls ...

Signed-off-by: Enrico Jorns <ejo@pengutronix.de>
Reviewed-by: Michael Olbrich <mol@pengutronix.de>
Signed-off-by: Roland Hieber <rhi@pengutronix.de>

Introduce dev_set_name() ...

This ports the following barebox commit:

| commit 0568376
| Author: Andrey Smirnov <andrew.smirnov@gmail.com>
| Date:   Tue Oct 16 12:15:40 2018 -0700
|
|     drivers: Introduce dev_set_name()
|
|     Introduce dev_set_name() in order to hide implementation details of
|     setting device's name so it'd be easier to change it.
|
|     Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
|     Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>
Signed-off-by: Roland Hieber <rhi@pengutronix.de>

state: fix documentation of state_new_from_node() ...

This ports the following barebox commit:

| commit 63b9aad
| Author: Ulrich Ölmann <u.oelmann@pengutronix.de>
| Date:   Fri Oct 12 08:48:48 2018 +0200
|
|     state: fix documentation of state_new_from_node()
|
|     Commit a66a8d79871c ("state: remove unused arguments from
|     state_new_from_node()") removed a little bit too much.
|
|     Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>
|     Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>
Signed-off-by: Roland Hieber <rhi@pengutronix.de>

backend_bucket_circular: remove unused variables ...

This ports the following barebox commit:

| commit 0d0a472
| Author: Ulrich Ölmann <u.oelmann@pengutronix.de>
| Date:   Wed Oct 10 14:23:40 2018 +0200
|
|     state: backend_bucket_circular: remove unused variables
|
|     This has been forgotten in commit 9d6d91931afb ("state: Remove -EUCLEAN
|     check
|     from userspace tool").
|
|     Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>
|     Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>
Signed-off-by: Roland Hieber <rhi@pengutronix.de>

state: fix typo ...

This ports the following barebox commit:

| commit f6a47cc
| Author: Ulrich Ölmann <u.oelmann@pengutronix.de>
| Date:   Mon Oct 8 20:02:06 2018 +0200
|
|     common: state: fix typo
|
|     Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>
|     Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>
Signed-off-by: Roland Hieber <rhi@pengutronix.de>

state: backend_bucket_circular: fix memory leak ...

This ports the following barebox commit:

| commit 87a0df3
| Author: Ulrich Ölmann <u.oelmann@pengutronix.de>
| Date:   Mon Oct 8 19:45:23 2018 +0200
|
|     state: backend_bucket_circular: fix memory leak
|
|     Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>
|     Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>
Signed-off-by: Roland Hieber <rhi@pengutronix.de>

state: backend_bucket_circular: fix for non power of 2 writesize ...

This includes sys/param.h to have the definition of roundup() and ports the
following barebox commit:

| commit f701414
| Author: Ladislav Michl <ladis@linux-mips.org>
| Date:   Tue Sep 25 12:58:45 2018 +0200
|
|     state: backend_bucket_circular: fix for non power of 2 writesize
|
|     backend_bucket_circular currently assumes writesize is power of 2,
|     which makes it fail on dataflash devices, where this assumption
|     is false.
|
|     Signed-off-by: Ladislav Michl <ladis@linux-mips.org>
|     Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>
Signed-off-by: Roland Hieber <rhi@pengutronix.de>

state: Add property to protect existing data ...

This ports the following barebox commit:

| commit 67c1c08
| Author: Daniel Schultz <d.schultz@phytec.de>
| Date:   Thu Apr 12 11:13:01 2018 +0200
|
|     common: state: Add property to protect existing data
|
|     After an update to a newer barebox version with an enabled state
|     framework, existing data in storage memories could be overwritten.
|
|     Add a new property to check in front of every write task, if the meta
|     magic field only contains the magic number, zeros or ones.
|
|     Signed-off-by: Daniel Schultz <d.schultz@phytec.de>
|     Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>
Signed-off-by: Roland Hieber <rhi@pengutronix.de>

state: find backend node with its reproducible name ...

This ports the following barebox commit and removes the now no longer used noop
definition of of_find_node_by_devpath() that was introduced in commit "state:
find device node from device path, not from device node path":

| commit 1eddb0d
| Author: Sascha Hauer <s.hauer@pengutronix.de>
| Date:   Tue Feb 20 12:41:26 2018 +0100
|
|     state: find backend node with its reproducible name
|
|     When fixing up the kernels state nodes we depended on the full node path
|     of the input device tree. This does not work when the kernel device tree
|     has different names. This has happened lately when the i.MX6 device
|     trees got their leading zeroes removed from the node names.
|
|     Use of_find_node_by_reproducible_name() to find the node corresponding
|     to the storage backend node in the kernel device tree.
|
|     Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>
Signed-off-by: Roland Hieber <rhi@pengutronix.de>

state: remove unused arguments from state_new_from_node() ...

Other than in barebox the offset and size of a state's backend device do not
necessarily equal zero in Linux userspace (EEPROMs & block devices). So we have
to consider that and differentiate between both usecases here while porting the
following barebox commit and removing the now no longer used noop definition of
of_find_path_by_node():

| commit a66a8d7
| Author: Sascha Hauer <s.hauer@pengutronix.de>
| Date:   Tue Feb 20 12:21:00 2018 +0100
|
|     state: remove unused arguments from state_new_from_node()
|
|     state_new_from_node() has arguments describing the backend path. These
|     are never used in barebox, the backend path is always derived from the
|     device nodes backend description. Remove these arguments.
|
|     Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>
[rhi: fixed tabs vs. spaces indentation in state_new_from_node()]
Signed-off-by: Roland Hieber <rhi@pengutronix.de>

state: Add 'init_from_defaults' parameter ...

This ports the following barebox commit:

| commit 6a77d1c
| Author: Sascha Hauer <s.hauer@pengutronix.de>
| Date:   Wed May 4 12:01:05 2016 +0200
|
|     state: Add 'init_from_defaults' parameter
|
|     The init_from_defaults parameter allows to detect if a state has been
|     initialized from default values, i.e. state_load failed.
|
|     Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>
Signed-off-by: Roland Hieber <rhi@pengutronix.de>

state: refuse to set dirty parameter via setenv ...

This ports the following barebox commit:

| commit 6d3e10c
| Author: Sascha Hauer <s.hauer@pengutronix.de>
| Date:   Wed May 4 11:59:59 2016 +0200
|
|     state: refuse to set dirty parameter via setenv
|
|     The dirty parameter is readonly, so refuse to set it.
|
|     Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>
Signed-off-by: Roland Hieber <rhi@pengutronix.de>

state: Add function to read state MAC ...

This ports the following barebox commit:

| commit 09f15cd
| Author: Daniel Schultz <d.schultz@phytec.de>
| Date:   Fri Nov 3 11:48:28 2017 +0100
|
|     common: state: Add function to read state MAC
|
|     This API function allows to receive a copy of a MAC address from
|     variables in a state.
|
|     Signed-off-by: Daniel Schultz <d.schultz@phytec.de>
|     Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>
Signed-off-by: Roland Hieber <rhi@pengutronix.de>

state: refactor variable type ...

This ports the following barebox commits and adjusts the handling of type
information of state variables in barebox-state:

| commit 7b3d284
| Author: Sascha Hauer <s.hauer@pengutronix.de>
| Date:   Mon Apr 3 22:51:58 2017 +0200
|
|     state: remove unused variable type
|
|     enum state_variable_type is never used. Remove it.
|
|     Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

| commit 7126dff
| Author: Daniel Schultz <d.schultz@phytec.de>
| Date:   Fri Nov 3 11:48:26 2017 +0100
|
|     common: state: Add variable_type to state_variable
|
|     Add a pointer in state_variable to the corresponding variable_type array
|     element.
|
|     Signed-off-by: Daniel Schultz <d.schultz@phytec.de>
|     Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

| commit dc74265
| Author: Daniel Schultz <d.schultz@phytec.de>
| Date:   Fri Nov 3 11:48:27 2017 +0100
|
|     common: state: Add variable type as enum
|
|     The variable_type struct holds a name of its type. Checking the type of
|     a variable with this string needs much resources.
|
|     This patch introduce a enum of the variable type for better type
|     checking.
|
|     Signed-off-by: Daniel Schultz <d.schultz@phytec.de>
|     Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>
[rhi: fixed function parameter alignment in common/state/state_variables.c,
  and submitted those changes as patches for barebox:
  https://www.mail-archive.com/barebox@lists.infradead.org/msg29427.html
  https://www.mail-archive.com/barebox@lists.infradead.org/msg29462.html ]
Signed-off-by: Roland Hieber <rhi@pengutronix.de>

state: remove checks for xzalloc() returning NULL ...

This ports the following barebox commit:

| commit 25e67cb
| Author: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
| Date:   Mon Sep 25 12:02:35 2017 +0200
|
|     remove checks for xzalloc() returning NULL
|
|     xzalloc() either returns memory or panics, so checking for NULL is useless.
|
|     Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
|     Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>
Signed-off-by: Roland Hieber <rhi@pengutronix.de>

libdt: xzalloc: die on failure ...

Behave like the well-known kernel variant, so existing code that
doesn't check xzallocs return value can be ported easier.

Signed-off-by: Roland Hieber <rhi@pengutronix.de>