state: backend_bucket_circular: fix double free() ...

The function state_mtd_peb_read() is only a user of buf and not its owner, hence
it may not deallocate it.

Signed-off-by: Kim Christensen <kch@skov.dk>
Reviewed-by: Ulrich Ölmann <u.oelmann@pengutronix.de>
Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Roland Hieber <rhi@pengutronix.de>

follow the Developer's Certificate of Origin ...

Signed-off-by: Roland Hieber <rhi@pengutronix.de>

remove leftovers from libabc skeleton ...

Additionally, remove the confusing disclaimer that this is public domain
software (which applies to the libabc template, not libdt or dt-utils –
we have COPYING for that).

Signed-off-by: Roland Hieber <rhi@pengutronix.de>

Don't install a pkg-config file for libdt ...

libdt isn't supposed to be installed as a system library as nobody wants
to care about things like a stable API. Also the generated .pc file is
completely bogus as it adds "-labc" to the linker instead of -ldt-utils.

So just drop generating and installing the pkg-config file.

dtblint-imx-pinmux: fix another set of wrong table entries

dtblint-imx-pinmux: fix swmux suggested values ...

Followup for a75ea34157c5

dtblint-imx-pinmux: fix another set of wrong table entries

dtblint-imx-pinmux: fix wrong table entry

dtblint: fsl,iomuxc: improve check for reserved bits ...

Some bits in the imx6dl iomux IP are reseverd and 1. The device tree is expected to specify
these bits as 1, so take swpad_reset_default into account for this check.

dtblint: add support for fsl,imx6dl-iomuxc

dtblint: check reset-gpio-active-high + reset-gpio for matching polarity

libdt: support finding devices by partuuid ...

This allows specifying partitions in devicetree that are actually not
described in the devicetree to allow referencing them:

    partitions {
            compatible = "fixed-partitions";
            #address-cells = <1>;
            #size-cells = <1>;

            state_part: state {
                    partuuid = "21367da7-c51f-499f-9aad-e1f366992365";
            };
    };

Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
Signed-off-by: Enrico Jorns <ejo@pengutronix.de>
Signed-off-by: Roland Hieber <rhi@pengutronix.de>

state: fix formatting of "uint32_t" variables ...

The format specifier "%zd" is for "size_t" typed variables and produces a
warning with gcc, so use "%u" instead.

Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>
Signed-off-by: Roland Hieber <rhi@pengutronix.de>

state: fix formatting of "off_t" variables ...

Explicitely casting an "off_t" variable to "long long" and formatting it via
"%lld" or "%llx" respectively makes 32- as well as 64-bit compilers
happy (tested with gcc-8.2.1 and clang-7.0.1).

Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>
Signed-off-by: Roland Hieber <rhi@pengutronix.de>

base64: remove duplicate ‘const’ declaration specifier ...

By cleaning up the code the compiler does not emit the following warning
anymore:

    src/base64.c:15:19: warning: duplicate ‘const’ declaration specifier [-Wduplicate-decl-specifier]
     static const char const uuenc_tbl_base64[65 + 1] = {
                       ^~~~~

Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>
Signed-off-by: Roland Hieber <rhi@pengutronix.de>

base64: remove unused variable ...

The variable seems to be a leftover from importing the function from
busybox-1.23.2 and by cleaning up the code the compiler does not emit the
following warning anymore:

    src/base64.c:34:14: warning: variable ‘src_tail’ set but not used [-Wunused-but-set-variable]
      const char *src_tail;
                  ^~~~~~~~

Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>
Signed-off-by: Roland Hieber <rhi@pengutronix.de>

keystore-blob: remove unused variable ...

By cleaning up the code the compiler does not emit the following warning
anymore:

    src/keystore-blob.c: In function 'keystore_get_secret':
    src/keystore-blob.c:25:15: warning: unused variable 'modifier' [-Wunused-variable]
      char *blob, *modifier, *payload;
                   ^~~~~~~~

Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>
Signed-off-by: Roland Hieber <rhi@pengutronix.de>

barebox-state: remove unused variables ...

By cleaning up the code the compiler does not emit the following warning
anymore:

    src/barebox-state.c: In function '__state_string_get':
    src/barebox-state.c:254:6: warning: unused variable 'ret' [-Wunused-variable]
      int ret;
          ^~~
    src/barebox-state.c: In function 'state_get':
    src/barebox-state.c:317:25: warning: unused variable 'v' [-Wunused-variable]
      struct state_variable *v;
                             ^
    src/barebox-state.c:316:14: warning: unused variable 'backend_type' [-Wunused-variable]
      const char *backend_type = NULL;
                  ^~~~~~~~~~~~
    src/barebox-state.c:313:8: warning: unused variable 'path' [-Wunused-variable]
      char *path;
            ^~~~
    src/barebox-state.c: In function 'main':
    src/barebox-state.c:561:9: warning: unused variable 'i' [-Wunused-variable]
         int i;
             ^

Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>
Signed-off-by: Roland Hieber <rhi@pengutronix.de>

barebox-state: remove declaration of __state_uint8_get() ...

By cleaning up the code the compiler does not emit the following warning
anymore:

    src/barebox-state.c:44:14: warning: ‘__state_uint8_get’ declared ‘static’ but never defined [-Wunused-function]
     static char *__state_uint8_get(struct state_variable *var);
                  ^~~~~~~~~~~~~~~~~

The function is not needed as its job is done by __state_uint32_get().

Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>
Signed-off-by: Roland Hieber <rhi@pengutronix.de>

barebox-state: add cmdline option "--version" ...

Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>
Signed-off-by: Roland Hieber <rhi@pengutronix.de>

barebox-state: complete cmdline options ...

Make the commandline options consistent and complete:

  - option "-h" already had a long equivalent "--help", so reflect that in the
    usage() message.
  - for option "-q" the usage() message promised a long equivalent "--quiet"
    that did not exist.
  - the call to getopt_long() already allowed the option "-f" in its optstring,
    but the usage() message said nothing about it, hence amend that and offer
    the long option "--force" as well.

Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>
Signed-off-by: Roland Hieber <rhi@pengutronix.de>

barebox-state: fix usage of multiple state instances ...

Let's assume there are two state instances named "blue" (with variable "x") and
"yellow" (with variable "y") then

  $ barebox-state --name blue --get x
  $ barebox-state --name yellow --get y

would both work, whereas only exactly one of the alternative calls

  $ barebox-state --get blue.x
  $ barebox-state --get yellow.y

would succeed. This commit fixes that bug.

Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>
Signed-off-by: Roland Hieber <rhi@pengutronix.de>

of_get_devicepath: again correct comment ...

The cited patch went mainline meanwhile so reflect that in the comment.

Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>
Signed-off-by: Roland Hieber <rhi@pengutronix.de>

common: align declarations of dev_add_param_*() functions with barebox ...

The only remaining difference is the argument "value" in dev_add_param_enum()
which is of type int* in barebox and got type uint32_t* here to not let the
compiler warn about assignment of pointers of different signedness.

There is no such warning when compiling barebox as it's applying the compiler
option "-Wno-pointer-sign" in its main makefile.

Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>
Signed-off-by: Roland Hieber <rhi@pengutronix.de>

state: fix typo ...

This ports the following barebox commit:

| commit 69b16bc
| Author: Ulrich Ölmann <u.oelmann@pengutronix.de>
| Date:   Wed Feb 6 11:34:02 2019 +0100
|
|     common: state: fix typo
|
|     Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>
|     Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
|
| M       common/state/backend_format_raw.c
| M       common/state/state.c
| M       common/state/state.h

Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>
Signed-off-by: Roland Hieber <rhi@pengutronix.de>

barebox-state: fix error message ...

Negative errnos result into "Unknown error -22" instead of "Invalid
argument". The latter is more helpful, while the first is mostly useless.

Signed-off-by: Juergen Borleis <jbe@pengutronix.de>

Release 2019.01.0 ...

Signed-off-by: Roland Hieber <rhi@pengutronix.de>

fix leaks of memory returned by read_file() calls ...

Signed-off-by: Enrico Jorns <ejo@pengutronix.de>
Reviewed-by: Michael Olbrich <mol@pengutronix.de>
Signed-off-by: Roland Hieber <rhi@pengutronix.de>

Introduce dev_set_name() ...

This ports the following barebox commit:

| commit 0568376
| Author: Andrey Smirnov <andrew.smirnov@gmail.com>
| Date:   Tue Oct 16 12:15:40 2018 -0700
|
|     drivers: Introduce dev_set_name()
|
|     Introduce dev_set_name() in order to hide implementation details of
|     setting device's name so it'd be easier to change it.
|
|     Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
|     Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>
Signed-off-by: Roland Hieber <rhi@pengutronix.de>

state: fix documentation of state_new_from_node() ...

This ports the following barebox commit:

| commit 63b9aad
| Author: Ulrich Ölmann <u.oelmann@pengutronix.de>
| Date:   Fri Oct 12 08:48:48 2018 +0200
|
|     state: fix documentation of state_new_from_node()
|
|     Commit a66a8d79871c ("state: remove unused arguments from
|     state_new_from_node()") removed a little bit too much.
|
|     Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>
|     Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>
Signed-off-by: Roland Hieber <rhi@pengutronix.de>