configure: remove build time option '--enable-debug' ...

If enabled it defined the C preprocessor macro 'DEBUG' which wasn't used
anywhere.

Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>

configure: remove build time option '--disable-logging' ...

If enabled it defined the C preprocessor macro 'ENABLE_LOGGING' which wasn't
used anywhere.

Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>

state: harmonize code with barebox ...

This ports the following barebox commit:

| commit cdbeddf
| Author: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
| Date:   Wed Sep 11 21:27:38 2019 +0200
|
|     state: provide dummy implementations for some functions when STATE is
|     disabled
|
|     This allows to simplify some callers as can be seen from the
|     phytec-som-am335x/board.c change. (The check for state != NULL could be
|     dropped already before.)
|
|     Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
|     Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>

state: harmonize code with barebox ...

Sort the function declarations in the same order that barebox uses.

Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>

state: backend_storage: harmonize code with barebox ...

This ports the following barebox commit:

| commit f389531
| Author: Lucas Stach <l.stach@pengutronix.de>
| Date:   Fri Jul 22 15:00:19 2016 +0200
|
|     state: only build circular backend if MTD is enabled
|
|     The circular backend depends on MTD symbols and is only useful
|     if MTD is present. Exclude it from the build if MTD is not enabled.
|
|     Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
|     Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>

state: keep backward compatibility ...

Introduce the new build time option '--enable-state-backward-compatibility' to
port the following barebox commit.

NOTE: This changes barebox-state's default behaviour.

| commit 480cde1
| Author: Juergen Borleis <jbe@pengutronix.de>
| Date:   Tue Aug 15 15:46:31 2017 +0200
|
|     state: keep backward compatibility
|
|     Previous 'state' variable set variants do not know and use metadata. The
|     'direct' storage backend's read function honors this, but not its
|     counterpart the write function. This makes an update of the 'state'
|     variable set impossible.
|     This change makes backward compatibility explicit, else it complains in
|     the read function as well. With some more debug output it helps the
|     developer to do things right.
|
|     Signed-off-by: Juergen Borleis <jbe@pengutronix.de>
|     Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>

state: drop unused code and declarations for non-existing functions ...

This ports the following barebox commit:

| commit 452a994
| Author: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
| Date:   Wed Sep 11 21:27:37 2019 +0200
|
|     state: drop unused code and declarations for non-existing functions
|
|     state_get_name() is not used and so can be removed.
|     state_backend_dtb_file() and state_backend_raw_file() were dropped in
|     c999b507da98 ("state: Refactor state framework").
|
|     Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
|     Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>

state: backend_bucket_circular: mark block as bad if mtd_peb_torture() failed ...

This ports the following barebox commit:

| commit 3b68dbc
| Author: Sascha Hauer <s.hauer@pengutronix.de>
| Date:   Mon Jul 15 15:28:55 2019 +0200
|
|     mtd: peb: Do not mark as bad in mtd_peb_torture()
|
|     Both the Kernel and mtd-utils have peb torture functions and both
|     do not mark the block as bad automatically. Instead, the caller
|     must mark the block as bad when -EIO is returned from the torture
|     function. Do the same in barebox. This is necessary as the UBI code
|     otherwise may mark a block as bad twice: Once indirectly in
|     mtd_peb_torture() and then directly afterwards.
|
|     Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>

state: check length ...

This ports the following barebox commit:

| commit 9271182
| Author: Jan Remmet <j.remmet@phytec.de>
| Date:   Thu May 23 09:49:00 2019 +0200
|
|     common: state: check length
|
|     if written_length is read from a partial written bucket it may be to
|     big and xmalloc will panic barebox.
|
|     Check if the value is sane. Make read_len unsigned to avoid negative
|     values.
|
|     Signed-off-by: Jan Remmet <j.remmet@phytec.de>
|     Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>

state: Fix lseek error check in state_mtd_peb_write() ...

This ports the following barebox commit:

| commit 5eadd11
| Author: Andrey Smirnov <andrew.smirnov@gmail.com>
| Date:   Wed Mar 6 23:49:24 2019 -0800
|
|     state: Fix lseek error check in state_mtd_peb_write()
|
|     Don't use 'int' to store lseek()'s return value to avoid problems with
|     large seek offsets. While at it, make sure to populate return error
|     code from 'errno'.
|
|     Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
|     Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>

state: Fix lseek error check in state_mtd_peb_read() ...

This ports the following barebox commit:

| commit 8a6a9fb
| Author: Andrey Smirnov <andrew.smirnov@gmail.com>
| Date:   Wed Mar 6 23:49:23 2019 -0800
|
|     state: Fix lseek error check in state_mtd_peb_read()
|
|     Don't use 'int' to store lseek()'s return value to avoid problems with
|     large seek offsets. While at it, make sure to populate return error
|     code from 'errno'.
|
|     Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
|     Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>

state: Fix lseek error check in state_backend_bucket_direct_write() ...

This ports the following barebox commit:

| commit ec25ecf
| Author: Andrey Smirnov <andrew.smirnov@gmail.com>
| Date:   Wed Mar 6 23:49:22 2019 -0800
|
|     state: Fix lseek error check in state_backend_bucket_direct_write()
|
|     Don't use 'int' to store lseek()'s return value to avoid problems with
|     large seek offsets. While at it, make sure to populate return error
|     code from 'errno'.
|
|     Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
|     Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>

state: Fix lseek error check in state_backend_bucket_direct_read() ...

This ports the following barebox commit:

| commit 219b954
| Author: Andrey Smirnov <andrew.smirnov@gmail.com>
| Date:   Wed Mar 6 23:49:21 2019 -0800
|
|     state: Fix lseek error check in state_backend_bucket_direct_read()
|
|     Don't use 'int' to store lseek()'s return value to avoid problems with
|     large seek offsets. While at it, make sure to populate return error
|     code from 'errno'.
|
|     Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
|     Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>

state: backend_bucket_circular: fix double free() ...

The function state_mtd_peb_read() is only a user of buf and not its owner, hence
it may not deallocate it.

Signed-off-by: Kim Christensen <kch@skov.dk>
Reviewed-by: Ulrich Ölmann <u.oelmann@pengutronix.de>
Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Roland Hieber <rhi@pengutronix.de>

follow the Developer's Certificate of Origin ...

Signed-off-by: Roland Hieber <rhi@pengutronix.de>

remove leftovers from libabc skeleton ...

Additionally, remove the confusing disclaimer that this is public domain
software (which applies to the libabc template, not libdt or dt-utils –
we have COPYING for that).

Signed-off-by: Roland Hieber <rhi@pengutronix.de>

Don't install a pkg-config file for libdt ...

libdt isn't supposed to be installed as a system library as nobody wants
to care about things like a stable API. Also the generated .pc file is
completely bogus as it adds "-labc" to the linker instead of -ldt-utils.

So just drop generating and installing the pkg-config file.

dtblint-imx-pinmux: fix another set of wrong table entries

dtblint-imx-pinmux: fix swmux suggested values ...

Followup for a75ea34157c5

dtblint-imx-pinmux: fix another set of wrong table entries

dtblint-imx-pinmux: fix wrong table entry

dtblint: fsl,iomuxc: improve check for reserved bits ...

Some bits in the imx6dl iomux IP are reseverd and 1. The device tree is expected to specify
these bits as 1, so take swpad_reset_default into account for this check.

dtblint: add support for fsl,imx6dl-iomuxc

dtblint: check reset-gpio-active-high + reset-gpio for matching polarity

libdt: support finding devices by partuuid ...

This allows specifying partitions in devicetree that are actually not
described in the devicetree to allow referencing them:

    partitions {
            compatible = "fixed-partitions";
            #address-cells = <1>;
            #size-cells = <1>;

            state_part: state {
                    partuuid = "21367da7-c51f-499f-9aad-e1f366992365";
            };
    };

Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
Signed-off-by: Enrico Jorns <ejo@pengutronix.de>
Signed-off-by: Roland Hieber <rhi@pengutronix.de>

state: fix formatting of "uint32_t" variables ...

The format specifier "%zd" is for "size_t" typed variables and produces a
warning with gcc, so use "%u" instead.

Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>
Signed-off-by: Roland Hieber <rhi@pengutronix.de>

state: fix formatting of "off_t" variables ...

Explicitely casting an "off_t" variable to "long long" and formatting it via
"%lld" or "%llx" respectively makes 32- as well as 64-bit compilers
happy (tested with gcc-8.2.1 and clang-7.0.1).

Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>
Signed-off-by: Roland Hieber <rhi@pengutronix.de>

base64: remove duplicate ‘const’ declaration specifier ...

By cleaning up the code the compiler does not emit the following warning
anymore:

    src/base64.c:15:19: warning: duplicate ‘const’ declaration specifier [-Wduplicate-decl-specifier]
     static const char const uuenc_tbl_base64[65 + 1] = {
                       ^~~~~

Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>
Signed-off-by: Roland Hieber <rhi@pengutronix.de>

base64: remove unused variable ...

The variable seems to be a leftover from importing the function from
busybox-1.23.2 and by cleaning up the code the compiler does not emit the
following warning anymore:

    src/base64.c:34:14: warning: variable ‘src_tail’ set but not used [-Wunused-but-set-variable]
      const char *src_tail;
                  ^~~~~~~~

Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>
Signed-off-by: Roland Hieber <rhi@pengutronix.de>

keystore-blob: remove unused variable ...

By cleaning up the code the compiler does not emit the following warning
anymore:

    src/keystore-blob.c: In function 'keystore_get_secret':
    src/keystore-blob.c:25:15: warning: unused variable 'modifier' [-Wunused-variable]
      char *blob, *modifier, *payload;
                   ^~~~~~~~

Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>
Signed-off-by: Roland Hieber <rhi@pengutronix.de>