state: pass struct state * to storage functions ...

We can get a state_backend_storage * and the device * from struct state,
so pass this to the storage functions rather than the two pointers.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

state: remove unnecessary argument from state_format_init ...

The device pointer is already in struct state, no need to pass it
around when a struct state * is already passed.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

state: open code state_backend_init in caller ...

Safes a lot of argument passing to a function that is used
only once.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

state: merge backend.c into state.c ...

The code in backend.c is too small to justify an extra file. Merge it
into state.c.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

state: Drop backend as extra struct type ...

struct state_backend is embedded into struct state. This additional
indirection does not have any real gain. Drop it.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

state: backend: remove len_hint argument from state_storage_read ...

The argument is 0 in the only caller, so remove the argument.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

state: backend: remove .get_packed_len ...

.get_packed_len isn't implemented by any backend, so remove the
hook and its potential caller.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

state: Use positive logic ...

bools with "non" in the names are rather confusing. Switch to
positive logic.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

state: Make pointing to the backend using a phandle the only supported method ...

All other methods are broken for some time already: When starting the
kernel the state code rewrites the state node in the device tree and
replaced the "backend" property with a phandle - even when the target
can't be described as a phandle. Since using phandles is the nicest way
to point to the storage device anyway remove the other methods.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

of: of_path: add of_find_node_by_devpath() ...

We already have of_find_path_by_node() which finds a device path
for a given device node. This is used by the state framework to
find its backend path. This path has to be translated back to
a device node when Linux is started. The current approach turned
out to be too simple: We assumed that the node path is the same
in the tree Linux is started with. This is not true in several
cases:
- partition nodes should have the name "partition@<offset>", but
  in several trees they have "partition@<num>"
- There are two different partition bindings: The legacy binding
  and the new one with an additional partitions subnode which has
  a compatible = "fixed-partitions" property.
The node path only stays the same when the internal tree uses the
same bindings and node names as the tree Linux is started with.

To overcome this limitation we create of_find_node_by_devpath()
which converts the device path back to a device node. It does
so by finding the device node of the hardware device rather than
the partition node. It then parses over the partitions in this
device node with the known bindings looking for a partition which
matches in offset and size to the barebox partition.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

of: partition: Register the of partition fixup for of partition users ...

at24, at25 and mci core are using of_parse_partitions(). Register the
fixup for them aswell.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

of: partitions: flag partitions from a partition table ...

We are going to call the of_partition_fixup for regular block
devices like MMC/SD aswell. Add a flag to partitions indicating
they are instanciated from a on-disk partition table so that they
won't be added as device tree partitions during fixup.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

of: partition: only create partition node when partitions exist ...

With the legacy partition binding we did not modify the device
node when no partition exist, but with the new binding we would
create the "partitions" node with compatible = "fixed-partitions".
Prevent that by catching the absence of partitions early.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

fs: devfs-core: replace DEVFS_IS_PARTITION flag with pointer to the master cdev ...

Instead of having a flag indicating a cdev is a partition on
some master cdev, just add a master pointer to the cdev, so
that we can also find out who the master is.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

fs: devfs-core: remove unused code ...

Partitions on mtd devices are implemented as mtd devices themselves
which have a ioctl hook. The DEVFS_IS_PARTITION flag is never set
for these devices, so the partition offset translation code in
fs/devfs-core.c is unused. Remove it.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

of: partition: Make partition fixup independent from mtd devices ...

The of partition parser is not only used for mtd device, but also
for regular block devices, so make the of_mtd_fixup code independent
of mtd devices also, so that other devices can be fixed up, too.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

cdev: Collect partitions on list ...

We currently do not have a way to iterate over all partitions of
a cdev. Change this.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

of: partition: support 64bit partition sizes ...

Do not assume that #address-cells and #size-cells are
both 1. Parse them appropriately to support devices
> 4GuB.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

mtd: of: Make used partition binding configurable ...

So far we used the legacy partition binding when fixing up the
mtd partition nodes. Change this to default to the new binding
with a "partitions" submode. Make this behaviour configurable
though: This creates a new of_binding device variable for
mtd devices. This can be set to:

- "new": Use the new partition binding (default)
- "legacy": Use the old partition binding
- "donttouch": Do not touch the partition node

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

of: partition: Move of_mtd_fixup to drivers/of/ ...

Move the fixup code where the parser code is already.
Since the code will not only be used for mtd in the future
drivers/of/ is a better place than drivers/mtd/.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

treewide: Use of_property_write_string() where appropriate ...

Replace users which use of_set_property() to set a property to a string
with of_property_write_string().

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

of: Add of_property_write_string() ...

Setting a property to a string is used many times. Create a convenience
function for it.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

openrisc: fix call to restart_handler_register_fn ...

Signed-off-by: Franck Jullien <franck.jullien@gmail.com>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

console: fix usbserial re-connect ...

With commit b4f55fcf355a ("console: expose consoles in devfs") consoles
got inserted, but never removed from devfs.
When dealing with USB consoles, barebox should be prepared for devices
spontaneously appering and disappering again (user disconnects and re-
connects the cable). If the devfs entry is not removed upon disconnect,
barebox will raise an error "device creation failed with File exists"
when the cable is connected again.

Remove devfs entries when consoles are de-registered.
Also change the error message, it's the devfs entry.

Signed-off-by: Alexander Kurz <akurz@blala.de>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

console: console_get_by_name: do not strcmp NULL ...

console_get_by_name iterates through the console_list using strcmp to mach
a given console by name. console_list may contain entries with devname = NULL,
inserted there e.g. by KEYBOARD_GPIO. In worst case loady -t usbserial
will crash barebox when strcmp hits 0 NULL devname:
> unable to handle NULL pointer dereference at address 0x00000000

Let console_get_by_name just ignore the anonymous consoles.

Signed-off-by: Alexander Kurz <akurz@blala.de>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

state: backend circular: Fix wrong comment ...

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

usb_kbd: release all keys on error / disconnect ...

Signed-off-by: Peter Mamonov <pmamonov@gmail.com>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

state: bucket_circular: -EUCLEAN means data could be read ...

-EUCLEAN returned from state_mtd_peb_read() means that the
data shall still be used. This fixes initialization of buckets
which need cleanup

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

state: bucket_cached: Fix reading pages which need cleanup ...

When the raw device returns -EUCLEAN we have to return
successfully to the upper layer, otherwise it will discard the
data.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

mtd: fix reading data from page that needs cleanup ...

mtd_read´() returns -EUCLEAN to indicate that a page needs cleanup.
This value shouldn't be returned from the mtd read file operation
since this should return the number of bytes read.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>