Merge branch 'for-next/checkpatch'

Release v2018.12.0 ...

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

checkpatch.pl: check for #if 0/#if 1 ...

The #if 0 or #if 1 is used to toggle features. Warn if #if 0 or #if 1
is present and suggest that they can be removed.

Based on 60f890105547f7a4 ("checkpatch: check for #if 0/#if 1")
Linux kernel commit.

Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

checkpatch.pl: use SPDX tag ...

Also add Joe's copyright.

Based on Linux kernel commit 882ea1d64eb3956
("scripts: use SPDX tag in get_maintainer and checkpatch").

Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

checkpatch.pl: check for common memset parameter issues against statements ...

Based on these Linux kernel commits

> 309c00c73f053a90 checkpatch: warn about memset with swapped arguments
> 554e165cf32610ec checkpatch: check for common memset parameter issues against statments

Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

checkpatch.pl: add ability to ignore various messages ...

Based on commit 000d1cc1829f938c ("checkpatch.pl: add
ability to ignore various messages") from Linux kernel.

This simplifies current linux kernel checkpatch.pl commit
adoption for barebox due to conversion of
1-argument ERROR($1), WARN($1) and CHK($1) subs into
2-argument ERROR($1, $2), WARN($1, $2) and CHK($1, $2) subs.

Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

documentation: document eMMC boot{0,1}-partitions binding ...

The described binding was implemented in commit 6e9a87b39
("mci: Allow to partition eMMC boot partitions").

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

phytec-som-imx6: ksz8081_phy_fixup: Don't override B-CAST_OFF strap-in ...

As PHY address 0 is not used on PHYTEC i.MX 6 and i.MX 6UL SOMs we do
not have to override the B-CAST_OFF strap-in which disables broadcast
on PHY address 0.

Also add some comments about the magic values.

Signed-off-by: Jan Remmet <j.remmet@phytec.de>
Signed-off-by: Stefan Riedmueller <s.riedmueller@phytec.de>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

common/parser.c: s/%d/%zu/ when printing size_t ...

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

lib: bootstrap: fix instance of possibly mismatched pointer sizes ...

len was int but &len is passed to read_file(..., size_t *size),
Fix this.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

defaultenv-2: add bnet script to second stage barebox over net ...

Doing cycling barebox boot over the net is a good testing practice.
It is possible to detect at least some bugs before flushing it to
the system. Suddenly it looks like, it is done not oft enough. So, let's
add this option mainline.

Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

serdev: select POLLER ...

A lot of the inner working of the serdev framework depend on the poller,
so there is no point in allowing to build without poller support.

Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

kconfig: include common Kconfig files from top-level Kconfig ...

Based on this linux kernel commit:

> commit 1572497
> Author: Christoph Hellwig <hch@lst.de>
> Date:   Tue Jul 31 13:39:30 2018 +0200
>
>     kconfig: include common Kconfig files from top-level Kconfig

Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

Add pr_memory_display ...

pr_memory_display is a memory_display variant that takes a MSG_*
loglevel priority with which the hexdump is printed. Like the
normal pr_* function this is optimized out when the priority is
below the compile time priority.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

memory_display: move prototype to include/printk.h ...

It's where the kernel has the print_hex_dump prototypes aswell, it's a
better match for these.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

memory_display: Print whole line at once ...

Instead of using many printf assemble a printed line first and
print it at once. This has the purpose of being able to pick
different output functions in the next step.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

clocksource: Add dw_apb_timer driver ...

Adapt linux kernel dw_apb_timer driver to barebox.

Signed-off-by: Jules Maselbas <jmaselbas@kalray.eu>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

Kconfig: Add clocksource menu ...

Signed-off-by: Jules Maselbas <jmaselbas@kalray.eu>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

imd: fix missing error message ...

imd -t just returns 'imd: error 61', if there is not tag for <type>

reference: common/imd.c:357 if (!imd) { ...
Signed-off-by: Thorsten K. Scherer <t.scherer@eckelmann.de>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

multiple/raspberry-pi: fix clkdevs for raspberry pi ...

Commit 7e497d4 introduced a name change which
breaks support for the fixed clkdev for uart and sdhci for RPI.
Use clkdev_add_physbase instead to be independant from the device tree names.

Signed-off-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

getopt: Add pr_fmt ...

To give the debug output more context.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

hush: Add extra define for hush debugging ...

I've seen people increasing the compile loglevel to get more debugging
output from barebox. This is generally a good idea, but the tons of hush
debugging printed makes barebox quite unusable. This patch puts hush
debugging behind an extra HUSH_DEBUG define so increasing the compile
loglevel no longer results in hush debugging.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

hush: Add pr_fmt define ...

To give the hush debug output more context.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

FIT: support hash-1/signature-1 nodes in signature check ...

The examples in the U-boot docs use "hash-N" and "signature-N" as the names
for hash/signature nodes. It seems "@N" was used instead at some point
during the development of the FIT format and "-N" is more correct (in fact,
dtc throws warnings when using "@N" without a reg attribute). Support for
the "@N" node names is preserved for backward compatibility.

Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

clk: fix NULL deref without OF node in debug message ...

of_clk_add_provider() may be called for devices added via
add_generic_device(). There is no OF node in this case, leading to a crash
when debug logs are enabled.

This affects various i.MX CPUs, which add imx*-ccm clock devices using
add_generic_device().

Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

mount command: Fix "mount /dev/<devname>" ...

We used to put the device name without the "/dev/" component into
device_detect_by_name() and cdev_by_name(). Since 8ca7053b3ff we only
put the device name into device_detect_by_name(), but cdev_by_name()
still gets the full path. The result is that a "mount /dev/<devname>" no
longer works. Fix this.

Fixes: 8ca7053b3ff ("commands: mount: Make use of devpath_to_name()")

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Andrey Smirnov <andrew.smirnov@gmail.com>

Add Raspberry Pi Zero W Board ...

The Raspberry Pi Zero W is basically a Raspberry Pi 1 B+
but on a smaller PCB and with Bluetooth and WiFi.
See:
https://elinux.org/RPi_Hardware

This patch adds support for Raspberry Pi Zero W to barebox.

Signed-off-by: Chris Fiege <chris@tinyhost.de>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

memory_display: add padding to simplify counting ...

Trying to count single bytes (e.g. when adding an offset) in 'word' or
'byte' output mode is not easy in the current formatting, and (at least
for me) has a high chance of miscounting or losing track of groups:

    barebox@boardname:/ md -b 0x149983f0+32
    149983f0: 18 00 00 00 00 00 0d 86 00 00 00 00 00 00 00 00    ................
    14998400: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00    ................

    barebox@boardname:/ md -w 0x149983f0+32
    149983f0: 0018 0000 0000 860d 0000 0000 0000 0000            ................
    14998400: 0000 0000 0000 0000 0000 0000 0000 0000            ................

With an additional space after 8 bytes, counting becomes easier:

    barebox@boardname:/ md -b 0x149983f0+32
    149983f0: 18 00 00 00 00 00 0d 86  00 00 00 00 00 00 00 00   ................
    14998400: 00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00   ................

    barebox@boardname:/ md -w 0x149983f0+32
    149983f0: 0018 0000 0000 860d  0000 0000 0000 0000           ................
    14998400: 0000 0000 0000 0000  0000 0000 0000 0000           ................

The 'quad' and 'long' output modes stay the same and are already much
more easier to count because they build bigger and therefore less groups
of bytes per line.

Signed-off-by: Roland Hieber <r.hieber@pengutronix.de>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

printk: make line continuation not result in stray emergency errors ...

The levels of pr_emerg() and pr_cont() are both set to 0. When pr_cont()
is used to continue a previous line, and colored console output is
enabled, this can result in garbled log messages being printed, e.g.:

    ERROR: HABv4: -------- HAB warning Event 0 --------
    ERROR: HABv4: event data:
    ERROR: HABv4:  dbEMERG:  00EMERG:  24EMERG:  42EMERG:   69EMERG:  30EMERG:  e1EMERG:  1d
    ERROR: HABv4:  00EMERG:  04EMERG:  00EMERG:  02EMERG:   40EMERG:  00EMERG:  36EMERG:  06
    ERROR: HABv4:  55EMERG:  55EMERG:  00EMERG:  03EMERG:   00EMERG:  00EMERG:  00EMERG:  00
    ERROR: HABv4:  00EMERG:  00EMERG:  00EMERG:  00EMERG:   00EMERG:  00EMERG:  00EMERG:  00
    ERROR: HABv4:  00EMERG:  00EMERG:  00EMERG:  01EMERG:
    ERROR: HABv4: Status: Operation completed with warning (0x69)

Note the additional "EMERG: " in front of each continuation, which is
inserted by pr_cont(buf) being expanded to pr_printk(0, buf). These
additional strings show up in deep red on the console (which is not
supported in Git commit messages…). One might argue that this is the
same color as the "ERROR: " prefix, but when pr_cont() is used with
pr_notice() and pr_warning(), which are printed in blue and yellow
respectively, at least then the change in color would lead to additional
confusion.

The log level argument to pr_printk is defined as int, so we can solve
this by defining the level for pr_cont() to -1, which is not used for
any loglevel:

    ERROR: HABv4: -------- HAB warning Event 0 --------
    ERROR: HABv4: event data:
    ERROR: HABv4:  db 00 24 42  69 30 e1 1d
    ERROR: HABv4:  00 04 00 02  40 00 36 06
    ERROR: HABv4:  55 55 00 03  00 00 00 00
    ERROR: HABv4:  00 00 00 00  00 00 00 00
    ERROR: HABv4:  00 00 00 01
    ERROR: HABv4: Status: Operation completed with warning (0x69)

Fixes: 0fcefdd ("printk: Add pr_cont")
Fixes: ea0e077 ("printk: Fix pr_cont")
Signed-off-by: Roland Hieber <r.hieber@pengutronix.de>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

lib: lodepng: remove useless test ...

Either the condition 'code_ll==(unsigned int)(-1)' is redundant or the
array 'LENGTHBASE[29]' is accessed at index 4294967038, which is out of
bounds.

On other hand this condition is tested within other scope:
"if(code_ll >= FIRST_LENGTH_CODE_INDEX && code_ll <= LAST_LENGTH_CODE_INDEX)"
with is already limited to (code_ll >= 257 && code_ll <= 285),
so it can't be -1 any way.

Signed-off-by: Oleksij Rempel <linux@rempel-privat.de>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>